Chromium Code Reviews| Index: chrome/browser/resources/feedback/js/feedback.js |
| diff --git a/chrome/browser/resources/feedback/js/feedback.js b/chrome/browser/resources/feedback/js/feedback.js |
| index 0b929ac2a4aecb4bf7777240a766b00f41f2af3d..c5a8433879843eacf2dc827113ef1ea8a7045928 100644 |
| --- a/chrome/browser/resources/feedback/js/feedback.js |
| +++ b/chrome/browser/resources/feedback/js/feedback.js |
| @@ -204,6 +204,15 @@ function sendReport() { |
| if (!$('screenshot-checkbox').checked) |
| feedbackInfo.screenshot = null; |
| + var productId = parseInt('' + feedbackInfo.productId); |
| + if (isNaN(productId)) { |
| + // For apps that still use a string value as the |productId|, we must clear |
|
Devlin
2016/08/03 18:04:36
Which apps are these? Do they all go through this
afakhry
2016/08/03 20:16:10
For the whitelisted apps, I sent an alert email to
Devlin
2016/08/03 22:11:50
Awesome, thanks!
|
| + // that value since the API uses an integer value, and a conflict in data |
| + // types will cause the report to fail to be sent. |
| + productId = null; |
| + } |
| + feedbackInfo.productId = productId; |
| + |
| // Request sending the report, show the landing page (if allowed), and close |
| // this window right away. The FeedbackRequest object that represents this |
| // report will take care of sending the report in the background. |