Chromium Code Reviews| Index: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc |
| diff --git a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc |
| index d2b91949ef5ca2fbb5906c80ea7fbfe8e85f65e3..c765aa747409e253fc17f82595612c0fa7a27469 100644 |
| --- a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc |
| +++ b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc |
| @@ -240,19 +240,23 @@ bool FeedbackPrivateSendFeedbackFunction::RunAsync() { |
| std::string attached_file_uuid; |
| if (feedback_info.attached_file_blob_uuid.get() && |
| - !feedback_info.attached_file_blob_uuid->empty()) |
| + !feedback_info.attached_file_blob_uuid->empty()) { |
| attached_file_uuid = *feedback_info.attached_file_blob_uuid; |
| + } |
| std::string screenshot_uuid; |
| if (feedback_info.screenshot_blob_uuid.get() && |
| - !feedback_info.screenshot_blob_uuid->empty()) |
| + !feedback_info.screenshot_blob_uuid->empty()) { |
| screenshot_uuid = *feedback_info.screenshot_blob_uuid; |
| + } |
| // Populate feedback data. |
| scoped_refptr<FeedbackData> feedback_data(new FeedbackData()); |
| feedback_data->set_context(GetProfile()); |
| feedback_data->set_description(feedback_info.description); |
| + if (feedback_info.product_id.get()) |
|
Devlin
2016/08/03 18:04:36
optional nit: technically, all these .get()s are s
afakhry
2016/08/03 20:16:10
That's a very good nit. I was actually thinking ab
|
| + feedback_data->set_product_id(*feedback_info.product_id); |
| if (feedback_info.category_tag.get()) |
| feedback_data->set_category_tag(*feedback_info.category_tag); |
| if (feedback_info.page_url.get()) |