Sent feedback reports must respect the product ID if any was provided

chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/feedback_private/feedback_private_api.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/lazy_instance.h"
@@ skipping 222 matching lines @@
 
 bool FeedbackPrivateSendFeedbackFunction::RunAsync() {
   std::unique_ptr<feedback_private::SendFeedback::Params> params(
       feedback_private::SendFeedback::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
   const FeedbackInfo &feedback_info = params->feedback;
 
   std::string attached_file_uuid;
   if (feedback_info.attached_file_blob_uuid.get() &&
-      !feedback_info.attached_file_blob_uuid->empty())
+      !feedback_info.attached_file_blob_uuid->empty()) {
     attached_file_uuid = *feedback_info.attached_file_blob_uuid;
+  }
 
   std::string screenshot_uuid;
   if (feedback_info.screenshot_blob_uuid.get() &&
-      !feedback_info.screenshot_blob_uuid->empty())
+      !feedback_info.screenshot_blob_uuid->empty()) {
     screenshot_uuid = *feedback_info.screenshot_blob_uuid;
+  }
 
   // Populate feedback data.
   scoped_refptr<FeedbackData> feedback_data(new FeedbackData());
   feedback_data->set_context(GetProfile());
   feedback_data->set_description(feedback_info.description);
 
+  if (feedback_info.product_id.get())

[Devlin, 2016/08/03 18:04:36]

optional nit: technically, all these .get()s are superfluous, because
std::unique_ptr has a bool operator.  I'll leave it up to you if you want to
leave them in.

[afakhry, 2016/08/03 20:16:10]

That's a very good nit. I was actually thinking about doing it, but I preferred
to be consistent with the rest of the code here. Now that you mentioned it,
done!

+    feedback_data->set_product_id(*feedback_info.product_id);
   if (feedback_info.category_tag.get())
     feedback_data->set_category_tag(*feedback_info.category_tag);
   if (feedback_info.page_url.get())
     feedback_data->set_page_url(*feedback_info.page_url);
   if (feedback_info.email.get())
     feedback_data->set_user_email(*feedback_info.email);
 
   if (!attached_file_uuid.empty()) {
     feedback_data->set_attached_filename(
         StripFakepath((*feedback_info.attached_file).name));
@@ skipping 64 matching lines @@
       content::RecordAction(
           base::UserMetricsAction("Feedback.SrtPromptClosed"));
       break;
     default:
       return RespondNow(Error("Invalid arugment."));
   }
   return RespondNow(NoArguments());
 }
 
 }  // namespace extensions