Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2189233003: Move last of platform dependent init from //ui/gl to //ui/gl/init. (Closed)

Created:
4 years, 4 months ago by kylechar
Modified:
4 years, 4 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, ozone-reviews_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move last of platform dependent init from //ui/gl to //ui/gl/init. This CL moves the last two functions in gl_implementation_<platform>.cc from //ui/gl to //ui/gl/init. These functions will need to be in //ui/gl/init for Ozone to properly implement GLX. This also allows the platform dependent gl_implementation_<platform>.cc files to be deleted. BUG=611142 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/21dd510280003e6fa4b997237f0943ca4943ce99 Cr-Commit-Position: refs/heads/master@{#409594}

Patch Set 1 #

Patch Set 2 : Formatting. #

Patch Set 3 : Fix return values. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -186 lines) Patch
M gpu/config/gpu_info_collector.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gl/BUILD.gn View 3 chunks +0 lines, -7 lines 0 comments Download
M ui/gl/gl.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/gl/gl_egl_api_implementation.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_glx_api_implementation.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_implementation.h View 2 chunks +0 lines, -7 lines 0 comments Download
D ui/gl/gl_implementation_android.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D ui/gl/gl_implementation_mac.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D ui/gl/gl_implementation_ozone.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D ui/gl/gl_implementation_win.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D ui/gl/gl_implementation_x11.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M ui/gl/gl_wgl_api_implementation.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/init/gl_factory.h View 1 2 3 chunks +11 lines, -0 lines 0 comments Download
M ui/gl/init/gl_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/gl/init/gl_factory_android.cc View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
M ui/gl/init/gl_factory_mac.cc View 3 chunks +18 lines, -0 lines 0 comments Download
M ui/gl/init/gl_factory_ozone.cc View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
M ui/gl/init/gl_factory_win.cc View 1 2 2 chunks +21 lines, -0 lines 0 comments Download
M ui/gl/init/gl_factory_x11.cc View 1 2 2 chunks +21 lines, -0 lines 0 comments Download
M ui/gl/test/gl_image_test_support.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gl/test/gl_surface_test_support.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kylechar
4 years, 4 months ago (2016-08-02 18:01:00 UTC) #3
piman
LGTM, thanks!
4 years, 4 months ago (2016-08-03 16:43:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189233003/40001
4 years, 4 months ago (2016-08-03 18:05:39 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-03 19:41:29 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 19:42:43 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/21dd510280003e6fa4b997237f0943ca4943ce99
Cr-Commit-Position: refs/heads/master@{#409594}

Powered by Google App Engine
This is Rietveld 408576698