Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1333)

Issue 21891008: Don't attempt to transition JSProxy to an observed map / Object.getNotifier() must SetObserved (Closed)

Created:
7 years, 4 months ago by rafaelw
Modified:
7 years, 4 months ago
Reviewers:
adamk, rossberg
CC:
v8-dev
Visibility:
Public.

Description

I found this working on https://codereview.chromium.org/19541010/ The main problem is that if you called Object.getNotifier(obj) on an object, %SetObserved(object) would never get called on it, and thus it would be unobservable (new test added for this). Additionally, Runtime::SetObserved was asserting obj->IsJSObject() which would fail if called on a proxy. It just happens that our existing test always called getNotifier() before Object.observe on proxies, and thus we never previously attempted to transition the map of a proxy. Both issues are now fixed and properly tested. R=rossberg@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16074

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M src/object-observe.js View 1 chunk +4 lines, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/object-observe.js View 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rafaelw
7 years, 4 months ago (2013-08-02 22:29:30 UTC) #1
rossberg
LGTM, landing.
7 years, 4 months ago (2013-08-06 13:47:29 UTC) #2
rossberg
7 years, 4 months ago (2013-08-06 13:49:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16074 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698