src/runtime.cc - Issue 21891008: Don't attempt to transition JSProxy to an observed map / Object.getNotifier() must SetObserved

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 21891008: Don't attempt to transition JSProxy to an observed map / Object.getNotifier() must SetObserved (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index 97751470426cc62109970a2f17477e364c9e5ba4..2572c42369e608ed0c3fe9dd9ede322fc2e87930 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -13928,6 +13928,9 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_SetIsObserved) {

ASSERT(proto->IsJSGlobalObject());

obj = JSReceiver::cast(proto);

}

+ if (obj->IsJSProxy())

+ return isolate->heap()->undefined_value();

ASSERT(!(obj->map()->is_observed() && obj->IsJSObject() &&

JSObject::cast(obj)->HasFastElements()));

ASSERT(obj->IsJSObject());

« no previous file with comments | « src/object-observe.js ('k') | test/mjsunit/harmony/object-observe.js » ('j') | no next file with comments »