Make push messaging not create InvalidationService for login and guest

Make push messaging not create InvalidationService for login and guest

This CL prevents the push messaging API from creating InvalidationServices
for the Chrome OS login and guest profiles, which do not have GAIA
credentials and cannot use invalidation.

BUG=358169
TEST=Updated unit tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261780

[bartfab (slow), 2014-03-31 15:11:27]

Hi Daniel,

Could you please take a look?

[bartfab (slow), 2014-03-31 16:51:04]

Hi Drew,

Could you take a look at sync_backend_host_impl.cc?

[dcheng, 2014-03-31 17:48:26]

c/b/e/a/push_messaging/* LGTM

[dcheng, 2014-03-31 17:49:12]

On 2014/03/31 17:48:26, dcheng wrote:
> c/b/e/a/push_messaging/* LGTM

(And the stuff in c/b/invalidation)

[bartfab (slow), 2014-04-02 09:39:30]

Hi Drew,

Friendly review ping. It's just 2 lines :).

[Andrew T Wilson (Slow), 2014-04-02 11:10:33]

lgtm

[bartfab (slow), 2014-04-02 14:37:53]

I updated a number of unit tests so that they use a TestingProfileManager
instead of creating a TestingProfile directly.

Drew, could you review:
chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc
chrome/browser/sync/profile_sync_service_*_unittest.cc

Ryo, could you review:
chrome/browser/chromeos/drive/drive_integration_service_unittest.cc

Kinuko, could you review:
chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service_*unittest.cc

[hashimoto, 2014-04-03 04:48:34]

On 2014/04/02 14:37:53, bartfab wrote:
> I updated a number of unit tests so that they use a TestingProfileManager
> instead of creating a TestingProfile directly.
> 
> Drew, could you review:
> chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc
> chrome/browser/sync/profile_sync_service_*_unittest.cc
> 
> Ryo, could you review:
> chrome/browser/chromeos/drive/drive_integration_service_unittest.cc
> 
> Kinuko, could you review:
>
chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service_*unittest.cc
It seems the change description has nothing to do with the fix you made in
DriveIntegrationServiceTest.
Could you describe why we should use TestingProfileManager?
Using TestingProfile directly looks simpler to me.

[bartfab (slow), 2014-04-03 09:23:43]

On 2014/04/03 04:48:34, hashimoto wrote:
> On 2014/04/02 14:37:53, bartfab wrote:
> > I updated a number of unit tests so that they use a TestingProfileManager
> > instead of creating a TestingProfile directly.
> > 
> > Drew, could you review:
> > chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc
> > chrome/browser/sync/profile_sync_service_*_unittest.cc
> > 
> > Ryo, could you review:
> > chrome/browser/chromeos/drive/drive_integration_service_unittest.cc
> > 
> > Kinuko, could you review:
> >
>
chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service_*unittest.cc
> It seems the change description has nothing to do with the fix you made in
> DriveIntegrationServiceTest.
> Could you describe why we should use TestingProfileManager?
> Using TestingProfile directly looks simpler to me.

I added a comment explaining what the TestingProfileManager is needed for.

[hashimoto, 2014-04-03 10:09:18]

chrome/browser/chromeos/drive/drive_integration_service_unittest.cc lgtm thanks

[kinuko, 2014-04-03 10:16:59]

chrome/browser/sync_file_system/* lgtm

[Andrew T Wilson (Slow), 2014-04-03 11:00:39]

lgtm

[bartfab (slow), 2014-04-03 11:09:53]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2014-04-03 11:10:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/218903005/80001

[commit-bot: I haz the power, 2014-04-03 11:45:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-03 11:45:34]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[bartfab (slow), 2014-04-03 12:01:12]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2014-04-03 12:03:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/218903005/80001

[commit-bot: I haz the power, 2014-04-03 12:30:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-03 12:30:01]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[bartfab (slow), 2014-04-03 15:05:46]

Hi Nikita,

Could you take a look at chrome/browser/chromeos/profiles/*?

[bartfab (slow), 2014-04-03 15:10:45]

Hi Xiyuan,

I see that Nikita scheduled a "coding day" today, so botherhing him with code
reviews is probably a bad idea. Could you take a look at
chrome/browser/chromeos/profiles/*?

[Nikita (slow), 2014-04-03 15:15:18]

On 2014/04/03 15:10:45, bartfab wrote:
> Hi Xiyuan,
> 
> I see that Nikita scheduled a "coding day" today, so botherhing him with code
> reviews is probably a bad idea. Could you take a look at
> chrome/browser/chromeos/profiles/*?

no problem, done my coding for today :)

chrome/browser/chromeos/profiles/* lgtm

[Nikita (slow), 2014-04-03 15:15:25]

https://codereview.chromium.org/218903005/diff/100001/chrome/browser/chromeos...
File chrome/browser/chromeos/profiles/profile_util.cc (right):

https://codereview.chromium.org/218903005/diff/100001/chrome/browser/chromeos...
chrome/browser/chromeos/profiles/profile_util.cc:21: // Using
ProfileHelper::GetSigninProfile() here would lead to an infinite loop
nit: insert empty line before comment.

[bartfab (slow), 2014-04-03 15:23:34]

https://codereview.chromium.org/218903005/diff/100001/chrome/browser/chromeos...
File chrome/browser/chromeos/profiles/profile_util.cc (right):

https://codereview.chromium.org/218903005/diff/100001/chrome/browser/chromeos...
chrome/browser/chromeos/profiles/profile_util.cc:21: // Using
ProfileHelper::GetSigninProfile() here would lead to an infinite loop
On 2014/04/03 15:15:25, Nikita Kostylev wrote:
> nit: insert empty line before comment.

Done.

[bartfab (slow), 2014-04-03 15:23:51]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2014-04-03 15:26:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/218903005/120001

[commit-bot: I haz the power, 2014-04-03 16:42:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-03 16:42:45]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[bartfab (slow), 2014-04-04 09:44:36]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2014-04-04 09:44:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/218903005/140001

[commit-bot: I haz the power, 2014-04-04 10:00:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-04 10:00:54]

Try jobs failed on following builders:
  tryserver.chromium on mac_chromium_rel

[bartfab (slow), 2014-04-04 12:29:48]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2014-04-04 12:30:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/218903005/140001

[commit-bot: I haz the power, 2014-04-04 15:26:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/218903005/140001

[commit-bot: I haz the power, 2014-04-04 16:37:24]

Change committed as 261780