Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2188933002: Revert of Reland: Geolocation: move from content/browser to device/ (Closed)

Created:
4 years, 4 months ago by robliao
Modified:
4 years, 4 months ago
Reviewers:
mcasas, Paul Stewart
CC:
chromium-reviews, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, nasko+codewatch_chromium.org, browser-components-watch_chromium.org, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, mlamouri+watch-geolocation_chromium.org, lcwu+watch_chromium.org, sdefresne+watchlist_chromium.org, jam, gcasto+watch-blimp_chromium.org, Peter Beverloo, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, halliwell+watch_chromium.org, devtools-reviews_chromium.org, vabr+watchlistautofill_chromium.org, android-webview-reviews_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, lethalantidote+watch-blimp_chromium.org, rouslan+autofill_chromium.org, oshima+watch_chromium.org, Michael van Ouwerkerk, mlamouri+watch-permissions_chromium.org, alokp+watch_chromium.org, khushalsagar+watch-blimp_chromium.org, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, jdonnelly+autofillwatch_chromium.org, pfeldman, estade+watch_chromium.org, dtrainor+watch-blimp_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland: Geolocation: move from content/browser to device/ (patchset #2 id:20001 of https://codereview.chromium.org/2185993003/ ) Reason for revert: Build failure: FAILED: obj/device/geolocation/device_geolocation.network_location_request.obj ninja -t msvc -e environment.x64 -- "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\device\geolocation\device_geolocation.network_location_request.obj.rsp /c ..\..\device\geolocation\network_location_request.cc /Foobj\device\geolocation\device_geolocation.network_location_request.obj /Fdobj\device\geolocation\device_geolocation.cc.pdb c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): error C2220: warning treated as error - no 'object' file generated c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data Original issue's description: > Reland: Geolocation: move from content/browser to device/ > > Original CL was reverted because it broke Win Gyp Component-build > bot(s). This CL (PS2) defines the geolocation gyp component > correctly. > > Original CL description ------------------------------------------------ > Geolocation: move from content/browser to device/ > > This CL: > > - moves all of content/browser/geolocation to device/geolocation > - the public geolocation files in content/common/{browser, public} > are also relocated to device/geolocation > - the geolocation-specific unittests are compiled into > (already existing) device_unittests > - adds new fancy new device/geolocation BUILD.gn and > geolocation.gyp as well > - makes a component of geolocation (at least for gn) and that forces > adding geolocation_export.h (like other //device/ folders). > - Java Geolocation files are moved as well, and a new > geolocation_jni_registrar is added. > - classes are moved to device namespace. > > All paths and include/call sites updated, DEPS, BUILD.gn files, > gypi files etc. > > Some tricks: > - can't use BrowserThread::CurrentlyOn, etc; instead, the > task runner is cached on constructor and used for both thread > checking and PostTask()ing (a few unittest and wifi_data_provider* > needed that substitution). > - GeolocationServiceContext is moved to public/cpp so it can > be referenced from WebContentsImpl. > - MockLocationProvider.java is also moved to device/geolocation. > > BUG=612334 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > TBR=pstew@chromium.org > rationale:device/geolocation depends on dbus and this triggers > a DEPS presubmit rule -- however, this CL adds no new dependencies, > hence moving on in the interest of speed (and avoiding more rebases). > > Committed: https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7 > Cr-Commit-Position: refs/heads/master@{#408272} TBR=pstew@chromium.org,mcasas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=612334 Committed: https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94 Cr-Commit-Position: refs/heads/master@{#408303}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8133 lines, -6535 lines) Patch
M android_webview/browser/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/browser/aw_browser_main_parts.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/javatests/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/test/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M blimp/engine/BUILD.gn View 4 chunks +0 lines, -4 lines 0 comments Download
M blimp/engine/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/engine/app/blimp_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/feature/geolocation/blimp_location_provider.h View 3 chunks +7 lines, -7 lines 0 comments Download
M blimp/engine/feature/geolocation/blimp_location_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M blimp/engine/feature/geolocation/engine_geolocation_feature.h View 2 chunks +5 lines, -7 lines 0 comments Download
M blimp/engine/feature/geolocation/engine_geolocation_feature.cc View 7 chunks +16 lines, -16 lines 0 comments Download
M blimp/engine/feature/geolocation/engine_geolocation_feature_unittest.cc View 4 chunks +10 lines, -11 lines 0 comments Download
M blimp/engine/feature/geolocation/mock_blimp_location_provider_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/session/blimp_engine_session.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/BUILD.gn View 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/android/javatests/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector.h View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector_browsertest.cc View 4 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/geolocation/access_token_store_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/chrome_access_token_store.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/chrome_access_token_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/ui_test_utils.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chromecast/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/browser/cast_browser_main_parts.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chromecast/browser/geolocation/cast_access_token_store.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/geolocation/DEPS View 1 chunk +1 line, -2 lines 0 comments Download
M chromeos/geolocation/geoposition.h View 1 chunk +1 line, -1 line 0 comments Download
M components/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill.gypi View 1 chunk +2 lines, -8 lines 0 comments Download
M components/autofill/content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/content/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/content/browser/risk/fingerprint.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M components/autofill/content/browser/risk/fingerprint_browsertest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M content/app/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/android/library_loader_hooks.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/BUILD.gn View 5 chunks +25 lines, -3 lines 0 comments Download
M content/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/protocol/emulation_handler.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.h View 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 4 chunks +3 lines, -3 lines 0 comments Download
A content/browser/geolocation/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A content/browser/geolocation/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A content/browser/geolocation/empty_wifi_data_provider.h View 1 chunk +32 lines, -0 lines 0 comments Download
A content/browser/geolocation/empty_wifi_data_provider.cc View 1 chunk +28 lines, -0 lines 0 comments Download
A content/browser/geolocation/fake_access_token_store.h View 1 chunk +54 lines, -0 lines 0 comments Download
A content/browser/geolocation/fake_access_token_store.cc View 1 chunk +53 lines, -0 lines 0 comments Download
A content/browser/geolocation/geolocation_provider_impl.h View 1 chunk +102 lines, -0 lines 0 comments Download
A content/browser/geolocation/geolocation_provider_impl.cc View 1 chunk +202 lines, -0 lines 0 comments Download
A content/browser/geolocation/geolocation_provider_impl_unittest.cc View 1 chunk +262 lines, -0 lines 0 comments Download
A content/browser/geolocation/geolocation_service_context.h View 1 chunk +61 lines, -0 lines 0 comments Download
A content/browser/geolocation/geolocation_service_context.cc View 1 chunk +64 lines, -0 lines 0 comments Download
A content/browser/geolocation/geolocation_service_impl.h View 1 chunk +84 lines, -0 lines 0 comments Download
A content/browser/geolocation/geolocation_service_impl.cc View 1 chunk +195 lines, -0 lines 0 comments Download
A content/browser/geolocation/location_api_adapter_android.h View 1 chunk +85 lines, -0 lines 0 comments Download
A content/browser/geolocation/location_api_adapter_android.cc View 1 chunk +172 lines, -0 lines 0 comments Download
A content/browser/geolocation/location_arbitrator.h View 1 chunk +37 lines, -0 lines 0 comments Download
A content/browser/geolocation/location_arbitrator_impl.h View 1 chunk +128 lines, -0 lines 0 comments Download
A content/browser/geolocation/location_arbitrator_impl.cc View 1 chunk +213 lines, -0 lines 0 comments Download
A content/browser/geolocation/location_arbitrator_impl_unittest.cc View 1 chunk +443 lines, -0 lines 0 comments Download
A content/browser/geolocation/location_provider_android.h View 1 chunk +38 lines, -0 lines 0 comments Download
A content/browser/geolocation/location_provider_android.cc View 1 chunk +53 lines, -0 lines 0 comments Download
A content/browser/geolocation/location_provider_base.h View 1 chunk +36 lines, -0 lines 0 comments Download
A content/browser/geolocation/location_provider_base.cc View 1 chunk +28 lines, -0 lines 0 comments Download
A content/browser/geolocation/mock_location_arbitrator.h View 1 chunk +37 lines, -0 lines 0 comments Download
A content/browser/geolocation/mock_location_arbitrator.cc View 1 chunk +33 lines, -0 lines 0 comments Download
A content/browser/geolocation/mock_location_provider.h View 1 chunk +64 lines, -0 lines 0 comments Download
A content/browser/geolocation/mock_location_provider.cc View 1 chunk +124 lines, -0 lines 0 comments Download
A content/browser/geolocation/network_location_provider.h View 1 chunk +146 lines, -0 lines 0 comments Download
A content/browser/geolocation/network_location_provider.cc View 1 chunk +273 lines, -0 lines 0 comments Download
A content/browser/geolocation/network_location_provider_unittest.cc View 1 chunk +559 lines, -0 lines 0 comments Download
A content/browser/geolocation/network_location_request.h View 1 chunk +81 lines, -0 lines 0 comments Download
A content/browser/geolocation/network_location_request.cc View 1 chunk +427 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_data.h View 1 chunk +54 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_data.cc View 1 chunk +57 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_data_provider.h View 1 chunk +74 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_data_provider.cc View 1 chunk +54 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_data_provider_chromeos.h View 1 chunk +67 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_data_provider_chromeos.cc View 1 chunk +175 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_data_provider_chromeos_unittest.cc View 1 chunk +102 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_data_provider_common.h View 1 chunk +84 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_data_provider_common.cc View 1 chunk +91 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_data_provider_common_unittest.cc View 1 chunk +240 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_data_provider_common_win.h View 1 chunk +24 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_data_provider_common_win.cc View 1 chunk +57 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_data_provider_corewlan_mac.mm View 1 chunk +192 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_data_provider_linux.h View 1 chunk +40 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_data_provider_linux.cc View 1 chunk +381 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_data_provider_linux_unittest.cc View 1 chunk +237 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_data_provider_mac.h View 1 chunk +36 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_data_provider_mac.cc View 1 chunk +46 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_data_provider_manager.h View 1 chunk +97 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_data_provider_manager.cc View 1 chunk +98 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_data_provider_win.h View 1 chunk +30 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_data_provider_win.cc View 1 chunk +643 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_data_provider_win_unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download
A content/browser/geolocation/wifi_polling_policy.h View 1 chunk +57 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M content/content_browser.gypi View 9 chunks +66 lines, -0 lines 0 comments Download
M content/content_common.gypi View 3 chunks +3 lines, -2 lines 0 comments Download
M content/content_jni.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 8 chunks +26 lines, -2 lines 0 comments Download
M content/public/android/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A content/public/android/java/src/org/chromium/content/browser/LocationProviderAdapter.java View 1 chunk +100 lines, -0 lines 0 comments Download
A content/public/android/java/src/org/chromium/content/browser/LocationProviderFactory.java View 1 chunk +212 lines, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/LocationProviderTest.java View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
A content/public/browser/access_token_store.h View 1 chunk +56 lines, -0 lines 0 comments Download
A content/public/browser/geolocation_delegate.h View 1 chunk +39 lines, -0 lines 0 comments Download
A content/public/browser/geolocation_delegate.cc View 1 chunk +25 lines, -0 lines 0 comments Download
A content/public/browser/geolocation_provider.h View 1 chunk +71 lines, -0 lines 0 comments Download
A content/public/browser/location_provider.h View 1 chunk +58 lines, -0 lines 0 comments Download
A content/public/common/geoposition.h View 1 chunk +69 lines, -0 lines 0 comments Download
A content/public/common/geoposition.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M content/public/test/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/android/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
A content/public/test/android/javatests/src/org/chromium/content/browser/test/util/MockLocationProvider.java View 1 chunk +92 lines, -0 lines 0 comments Download
M content/public/test/content_test_suite_base.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/shell_access_token_store.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_browser_main_parts.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/test/BUILD.gn View 6 chunks +6 lines, -3 lines 0 comments Download
M device/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D device/geolocation/BUILD.gn View 1 chunk +0 lines, -200 lines 0 comments Download
D device/geolocation/DEPS View 1 chunk +0 lines, -9 lines 0 comments Download
D device/geolocation/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D device/geolocation/access_token_store.h View 1 chunk +0 lines, -56 lines 0 comments Download
D device/geolocation/android/geolocation_jni_registrar.h View 1 chunk +0 lines, -24 lines 0 comments Download
D device/geolocation/android/geolocation_jni_registrar.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D device/geolocation/android/java/org/chromium/device/geolocation/LocationProviderAdapter.java View 1 chunk +0 lines, -100 lines 0 comments Download
D device/geolocation/android/java/org/chromium/device/geolocation/LocationProviderFactory.java View 1 chunk +0 lines, -212 lines 0 comments Download
D device/geolocation/android/java/org/chromium/device/geolocation/MockLocationProvider.java View 1 chunk +0 lines, -89 lines 0 comments Download
D device/geolocation/empty_wifi_data_provider.h View 1 chunk +0 lines, -32 lines 0 comments Download
D device/geolocation/empty_wifi_data_provider.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D device/geolocation/fake_access_token_store.h View 1 chunk +0 lines, -54 lines 0 comments Download
D device/geolocation/fake_access_token_store.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D device/geolocation/geolocation.gyp View 1 chunk +0 lines, -133 lines 0 comments Download
D device/geolocation/geolocation_delegate.h View 1 chunk +0 lines, -39 lines 0 comments Download
D device/geolocation/geolocation_delegate.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D device/geolocation/geolocation_export.h View 1 chunk +0 lines, -28 lines 0 comments Download
D device/geolocation/geolocation_provider.h View 1 chunk +0 lines, -71 lines 0 comments Download
D device/geolocation/geolocation_provider_impl.h View 1 chunk +0 lines, -106 lines 0 comments Download
D device/geolocation/geolocation_provider_impl.cc View 1 chunk +0 lines, -200 lines 0 comments Download
D device/geolocation/geolocation_provider_impl_unittest.cc View 1 chunk +0 lines, -258 lines 0 comments Download
D device/geolocation/geolocation_service_context.h View 1 chunk +0 lines, -64 lines 0 comments Download
D device/geolocation/geolocation_service_context.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D device/geolocation/geolocation_service_impl.h View 1 chunk +0 lines, -84 lines 0 comments Download
D device/geolocation/geolocation_service_impl.cc View 1 chunk +0 lines, -195 lines 0 comments Download
D device/geolocation/geoposition.h View 1 chunk +0 lines, -69 lines 0 comments Download
D device/geolocation/geoposition.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D device/geolocation/location_api_adapter_android.h View 1 chunk +0 lines, -85 lines 0 comments Download
D device/geolocation/location_api_adapter_android.cc View 1 chunk +0 lines, -172 lines 0 comments Download
D device/geolocation/location_arbitrator.h View 1 chunk +0 lines, -37 lines 0 comments Download
D device/geolocation/location_arbitrator_impl.h View 1 chunk +0 lines, -129 lines 0 comments Download
D device/geolocation/location_arbitrator_impl.cc View 1 chunk +0 lines, -212 lines 0 comments Download
D device/geolocation/location_arbitrator_impl_unittest.cc View 1 chunk +0 lines, -442 lines 0 comments Download
D device/geolocation/location_provider.h View 1 chunk +0 lines, -58 lines 0 comments Download
D device/geolocation/location_provider_android.h View 1 chunk +0 lines, -38 lines 0 comments Download
D device/geolocation/location_provider_android.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D device/geolocation/location_provider_base.h View 1 chunk +0 lines, -36 lines 0 comments Download
D device/geolocation/location_provider_base.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D device/geolocation/mock_location_arbitrator.h View 1 chunk +0 lines, -37 lines 0 comments Download
D device/geolocation/mock_location_arbitrator.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D device/geolocation/mock_location_provider.h View 1 chunk +0 lines, -64 lines 0 comments Download
D device/geolocation/mock_location_provider.cc View 1 chunk +0 lines, -124 lines 0 comments Download
D device/geolocation/network_location_provider.h View 1 chunk +0 lines, -146 lines 0 comments Download
D device/geolocation/network_location_provider.cc View 1 chunk +0 lines, -273 lines 0 comments Download
D device/geolocation/network_location_provider_unittest.cc View 1 chunk +0 lines, -559 lines 0 comments Download
D device/geolocation/network_location_request.h View 1 chunk +0 lines, -81 lines 0 comments Download
D device/geolocation/network_location_request.cc View 1 chunk +0 lines, -427 lines 0 comments Download
D device/geolocation/wifi_data.h View 1 chunk +0 lines, -54 lines 0 comments Download
D device/geolocation/wifi_data.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D device/geolocation/wifi_data_provider.h View 1 chunk +0 lines, -74 lines 0 comments Download
D device/geolocation/wifi_data_provider.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D device/geolocation/wifi_data_provider_chromeos.h View 1 chunk +0 lines, -75 lines 0 comments Download
D device/geolocation/wifi_data_provider_chromeos.cc View 1 chunk +0 lines, -175 lines 0 comments Download
D device/geolocation/wifi_data_provider_chromeos_unittest.cc View 1 chunk +0 lines, -102 lines 0 comments Download
D device/geolocation/wifi_data_provider_common.h View 1 chunk +0 lines, -85 lines 0 comments Download
D device/geolocation/wifi_data_provider_common.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D device/geolocation/wifi_data_provider_common_unittest.cc View 1 chunk +0 lines, -239 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188933002/1
4 years, 4 months ago (2016-07-28 01:15:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 01:19:35 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6a5f51a5304bdcff7eea91f71be843b72c160d94 Cr-Commit-Position: refs/heads/master@{#408303}
4 years, 4 months ago (2016-07-28 01:21:13 UTC) #6
findit-for-me
4 years, 4 months ago (2016-07-28 01:55:40 UTC) #7
Message was sent while issue was closed.
FYI: Findit try jobs (rerunning failed compile or tests) identified this CL
at revision 408303 as the culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Powered by Google App Engine
This is Rietveld 408576698