Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2188723005: [interpreter] Add test for OSR from within generators. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Add test for OSR from within generators. R=neis@chromium.org TEST=mjsunit/ignition/osr-from-generator BUG=v8:4764 Committed: https://crrev.com/fcdcff5605901f5320a773d6da727ecf41917d18 Cr-Commit-Position: refs/heads/master@{#38125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1 line) Patch
M src/interpreter/bytecode-generator.cc View 1 chunk +0 lines, -1 line 0 comments Download
A test/mjsunit/ignition/osr-from-generator.js View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Michael Starzinger
Note that the tests only actually trigger OSR when generators no longer disable optimization (for ...
4 years, 4 months ago (2016-07-28 09:13:58 UTC) #3
neis
lgtm
4 years, 4 months ago (2016-07-28 09:18:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188723005/1
4 years, 4 months ago (2016-07-28 09:47:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 09:49:36 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fcdcff5605901f5320a773d6da727ecf41917d18 Cr-Commit-Position: refs/heads/master@{#38125}
4 years, 4 months ago (2016-07-28 09:50:06 UTC) #13
rmcilroy
4 years, 4 months ago (2016-07-28 11:15:19 UTC) #14
Message was sent while issue was closed.
As discussed offline:
 - We could make ASTNumbering just disable Crankshaft if --turbo-from-bytecode
is enabled now.
 - It might be good to have a test something like: 
   for (var i = 0; i < 3; ++i) {
       yield i;
       if (i == 1) %OptimizeOsr();
   }

   so that the OSR code gets triggered and entered on the back-edge, and the
first thing done by the optimized OSR function is a suspend.

Powered by Google App Engine
This is Rietveld 408576698