Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Unified Diff: src/interpreter/bytecode-generator.cc

Issue 2188723005: [interpreter] Add test for OSR from within generators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/ignition/osr-from-generator.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/bytecode-generator.cc
diff --git a/src/interpreter/bytecode-generator.cc b/src/interpreter/bytecode-generator.cc
index 3cf25b982d7865ef5724d9856728e0fa9cc89f92..f6276da9a7ea954efba6d7799c7b438330166a6f 100644
--- a/src/interpreter/bytecode-generator.cc
+++ b/src/interpreter/bytecode-generator.cc
@@ -722,7 +722,6 @@ void BytecodeGenerator::VisitIterationHeader(IterationStatement* stmt,
// on-stack replacement when armed for the given loop nesting depth.
if (FLAG_ignition_osr) {
// TODO(4764): Merge this with another bytecode (e.g. {Jump} back edge).
- // TODO(4764): Investigate interaction with generators.
int level = Min(loop_depth_, AbstractCode::kMaxLoopNestingMarker - 1);
builder()->OsrPoll(level);
}
« no previous file with comments | « no previous file | test/mjsunit/ignition/osr-from-generator.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698