third_party/WebKit/Source/core/animation/AnimationTimeline.h - Issue 2188623006: Add pre finalizer to Animation to ensure compositor handles get cleaned up

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/AnimationTimeline.h

Issue 2188623006: Add pre finalizer to Animation to ensure compositor handles get cleaned up (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove AnimationTimeline pre-finalizer Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/Animation.cpp ('k') | third_party/WebKit/Source/core/animation/AnimationTimeline.cpp » ('j') | third_party/WebKit/Source/core/animation/AnimationTimeline.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/AnimationTimeline.h

diff --git a/third_party/WebKit/Source/core/animation/AnimationTimeline.h b/third_party/WebKit/Source/core/animation/AnimationTimeline.h

index 58ca7a36765ff3be28363548dafd17cbfbfe882b..1236bf75b103c3f65c4c14fdfeaa91df25d37fcc 100644

--- a/third_party/WebKit/Source/core/animation/AnimationTimeline.h

+++ b/third_party/WebKit/Source/core/animation/AnimationTimeline.h

@@ -51,7 +51,6 @@ class AnimationEffect;

// AnimationTimeline is constructed and owned by Document, and tied to its lifecycle.

class CORE_EXPORT AnimationTimeline final : public GarbageCollectedFinalized<AnimationTimeline>, public ScriptWrappable {

DEFINE_WRAPPERTYPEINFO();

- USING_PRE_FINALIZER(AnimationTimeline, dispose);

public:

class PlatformTiming : public GarbageCollectedFinalized<PlatformTiming> {

public:

@@ -64,7 +63,6 @@ public:

static AnimationTimeline* create(Document*, PlatformTiming* = nullptr);

~AnimationTimeline();

- void dispose();

void serviceAnimations(TimingUpdateReason);

void scheduleNextService();