third_party/WebKit/Source/core/animation/Animation.cpp - Issue 2188623006: Add pre finalizer to Animation to ensure compositor handles get cleaned up

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/Animation.cpp

Issue 2188623006: Add pre finalizer to Animation to ensure compositor handles get cleaned up (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove AnimationTimeline pre-finalizer Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/Animation.h ('k') | third_party/WebKit/Source/core/animation/AnimationTimeline.h » ('j') | third_party/WebKit/Source/core/animation/AnimationTimeline.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/Animation.cpp

diff --git a/third_party/WebKit/Source/core/animation/Animation.cpp b/third_party/WebKit/Source/core/animation/Animation.cpp

index 62bb7c8f1af396eea05e5455e3b9f1c75de9b6d8..235ea4e2cf9190095d1ed00442a23a16b275e969 100644

--- a/third_party/WebKit/Source/core/animation/Animation.cpp

+++ b/third_party/WebKit/Source/core/animation/Animation.cpp

@@ -903,6 +903,9 @@ void Animation::endUpdatingState()

void Animation::createCompositorPlayer()

{

if (Platform::current()->isThreadedAnimationEnabled() && !m_compositorPlayer) {

+ // We only need to pre-finalize if we are running animations on the compositor.

+ ThreadState::current()->registerPreFinalizer(this);

ASSERT(Platform::current()->compositorSupport());

m_compositorPlayer = CompositorAnimationPlayer::create();

ASSERT(m_compositorPlayer);