third_party/WebKit/Source/core/animation/Animation.h - Issue 2188623006: Add pre finalizer to Animation to ensure compositor handles get cleaned up

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/Animation.h

Issue 2188623006: Add pre finalizer to Animation to ensure compositor handles get cleaned up (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove AnimationTimeline pre-finalizer Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/Animation.cpp » ('j') | third_party/WebKit/Source/core/animation/AnimationTimeline.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/Animation.h

diff --git a/third_party/WebKit/Source/core/animation/Animation.h b/third_party/WebKit/Source/core/animation/Animation.h

index 0559947b8bb34dc778450a3556bc34138d17351a..dceb4b4a94357c4b44c16f58f695cfb714a60473 100644

--- a/third_party/WebKit/Source/core/animation/Animation.h

+++ b/third_party/WebKit/Source/core/animation/Animation.h

@@ -62,6 +62,7 @@ class CORE_EXPORT Animation final

, public CompositorAnimationPlayerClient {

DEFINE_WRAPPERTYPEINFO();

USING_GARBAGE_COLLECTED_MIXIN(Animation);

+ USING_PRE_FINALIZER(Animation, dispose);

public:

enum AnimationPlayState {

Unset,

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/Animation.cpp » ('j') | third_party/WebKit/Source/core/animation/AnimationTimeline.cpp » ('J')