components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java - Issue 2188553002: Delete old NetworkQualityEstimator Cronet API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java

Issue 2188553002: Delete old NetworkQualityEstimator Cronet API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metrics-executor

Patch Set: rebase again. ugh. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/api/src/org/chromium/net/CronetEngine.java ('k') | components/cronet/android/cronet_url_request_context_adapter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java

diff --git a/components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java b/components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java

index f12904fc8b44e3bed7d4fc5820a9372d57b679ff..c18e4b21a3907392506e1dc99fdd5ba0325fe380 100644

--- a/components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java

+++ b/components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java

@@ -104,12 +104,6 @@ final class JavaCronetEngine extends CronetEngine {

}

@Override

- public void setRequestFinishedListenerExecutor(Executor executor) {}

- @Override

- public void enableNetworkQualityEstimator(Executor executor) {}

- @Override

public void configureNetworkQualityEstimatorForTesting(

boolean useLocalHostRequests, boolean useSmallerResponses) {}