Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: components/cronet/android/api/src/org/chromium/net/CronetEngine.java

Issue 2188553002: Delete old NetworkQualityEstimator Cronet API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metrics-executor
Patch Set: rebase again. ugh. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/api/src/org/chromium/net/CronetEngine.java
diff --git a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
index 5208651ce913a7e7d9ee5b133ecbaadf081c2a1b..95faf45ec2e59d314965447446f1b31aa227149b 100644
--- a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
+++ b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
@@ -959,34 +959,6 @@ public abstract class CronetEngine {
public abstract byte[] getGlobalMetricsDeltas();
/**
- * Sets the executor which will be used to notify RequestFinished
- * listeners, and to notify network quality RTT listeners
- * that do not provide an executor.
- * TODO(tbansal): http://crbug.com/618034 Remove this API. In short term,
- * once all Cronet embedders supply a valid executor with
- * NetworkQualityRTTListener, update the above comment to reflect that
- * {@link executor} is only used to notify RequestFinishedListeners.
- * @hide as it's a prototype.
- */
- public abstract void setRequestFinishedListenerExecutor(Executor executor);
-
- /**
- * Enables the network quality estimator, which collects and reports
- * measurements of round trip time (RTT) and downstream throughput at
- * various layers of the network stack. After enabling the estimator,
- * listeners of RTT and throughput can be added with
- * {@link #addRttListener} and {@link #addThroughputListener} and
- * removed with {@link #removeRttListener} and
- * {@link #removeThroughputListener}. The estimator uses memory and CPU
- * only when enabled.
- * @param executor an executor that will be used to notified all
- * added RTT and throughput listeners.
- * TODO(tbansal): http://crbug.com/618034 Remove this API.
- * @hide as it's a prototype.
- */
- public abstract void enableNetworkQualityEstimator(Executor executor);
-
- /**
* Configures the network quality estimator for testing. This must be called
* before round trip time and throughput listeners are added, and after the
* network quality estimator has been enabled.
@@ -1136,8 +1108,6 @@ public abstract class CronetEngine {
*
* @param listener the listener for finished requests.
*
- * TODO(tbansal): http://crbug.com/618034 Remove this API, once all embedders have switched to
- * using a request finished listener that provides its own executor.
* @hide as it's a prototype.
*/
public abstract void addRequestFinishedListener(RequestFinishedListener listener);
@@ -1147,8 +1117,6 @@ public abstract class CronetEngine {
*
* @param listener the listener to remove.
*
- * TODO(tbansal): http://crbug.com/618034 Remove this API, once all embedders have switched to
- * using a request finished listener that provides its own executor.
* @hide it's a prototype.
*/
public abstract void removeRequestFinishedListener(RequestFinishedListener listener);
« no previous file with comments | « no previous file | components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698