Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2188543002: Add Vulkan runtime dll (Closed)

Created:
4 years, 4 months ago by kjlubick
Modified:
4 years, 4 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add Vulkan runtime dll This gets copied into the out/ dir on compile and allows dm.exe to run anywhere, even if the Vulkan SDK is not installed. BUG=skia:5554 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188543002 Committed: https://skia.googlesource.com/skia/+/e772aeea0809c4d3cd6335f3359a5fed10806045

Patch Set 1 #

Patch Set 2 : Start changing recipes #

Patch Set 3 : Progress so far #

Patch Set 4 : remove check #

Patch Set 5 : move runtime to be put in in compile #

Patch Set 6 : git st #

Patch Set 7 : Fix presubmit #

Total comments: 4

Patch Set 8 : Remove Vulkan_flavor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -42 lines) Patch
M infra/bots/assets/win_vulkan_sdk/VERSION View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A infra/bots/assets/win_vulkan_sdk/create.py View 1 2 3 4 5 6 1 chunk +40 lines, -0 lines 0 comments Download
A + infra/bots/assets/win_vulkan_sdk/create_and_upload.py View 1 2 3 4 5 6 7 2 chunks +9 lines, -5 lines 0 comments Download
M infra/bots/recipe_modules/skia/api.py View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipe_modules/skia/default_flavor.py View 1 2 3 4 5 6 7 1 chunk +7 lines, -1 line 0 comments Download
M infra/bots/recipe_modules/skia/fake_specs.py View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Mac-Clang-Arm7-Debug-Android.json View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Mac-Clang-Arm7-Release-iOS.json View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Mac-Clang-x86_64-Debug-CommandBuffer.json View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Mac-Clang-x86_64-Release-CMake.json View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot.json View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-Arm7-Release-Android.json View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-Arm7-Release-Android_Vulkan.json View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Debug-MSAN.json View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Release-CMake.json View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Release-PDFium.json View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Release-Shared.json View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Release-Valgrind.json View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86-Debug.json View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86_64-Release-Vulkan.json View 1 2 3 4 5 2 chunks +39 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/big_issue_number.json View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/win_retry_failed_compile.json View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_trigger.py View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
kjlubick
4 years, 4 months ago (2016-07-27 18:35:18 UTC) #4
borenet
https://codereview.chromium.org/2188543002/diff/120001/infra/bots/assets/win_vulkan_sdk/create.py File infra/bots/assets/win_vulkan_sdk/create.py (right): https://codereview.chromium.org/2188543002/diff/120001/infra/bots/assets/win_vulkan_sdk/create.py#newcode1 infra/bots/assets/win_vulkan_sdk/create.py:1: #!/usr/bin/env python Please also add create_and_upload.py. https://codereview.chromium.org/2188543002/diff/120001/infra/bots/recipe_modules/skia/vulkan_flavor.py File infra/bots/recipe_modules/skia/vulkan_flavor.py ...
4 years, 4 months ago (2016-07-27 18:39:28 UTC) #6
kjlubick
https://codereview.chromium.org/2188543002/diff/120001/infra/bots/assets/win_vulkan_sdk/create.py File infra/bots/assets/win_vulkan_sdk/create.py (right): https://codereview.chromium.org/2188543002/diff/120001/infra/bots/assets/win_vulkan_sdk/create.py#newcode1 infra/bots/assets/win_vulkan_sdk/create.py:1: #!/usr/bin/env python On 2016/07/27 at 18:39:28, borenet wrote: > ...
4 years, 4 months ago (2016-07-27 18:51:27 UTC) #7
borenet
LGTM
4 years, 4 months ago (2016-07-27 18:53:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188543002/140001
4 years, 4 months ago (2016-07-27 19:09:52 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 19:59:15 UTC) #12
Message was sent while issue was closed. 
Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/e772aeea0809c4d3cd6335f3359a5fed10806045

Powered by Google App Engine
This is Rietveld 408576698