infra/bots/recipe_modules/skia/vulkan_flavor.py - Issue 2188543002: Add Vulkan runtime dll

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: infra/bots/recipe_modules/skia/vulkan_flavor.py

Issue 2188543002: Add Vulkan runtime dll (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: Fix presubmit Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import default_flavor

	6

	7 """Vulkan flavor utils, used for building Skia with Vulkan."""

	8

	9 class VulkanFlavorUtils(default_flavor.DefaultFlavorUtils):

	10 def copy_extra_build_products(self, swarming_out_dir):
	borenet 2016/07/27 18:39:28 I recommend doing this in default_flavor, since ev I recommend doing this in default_flavor, since eventually we'll be using Vulkan (almost) everywhere. kjlubick 2016/07/27 18:51:27 Done. Show quoted text On 2016/07/27 at 18:39:28, borenet wrote: > I recommend doing this in default_flavor, since eventually we'll be using Vulkan (almost) everywhere. Done.
	11 if "Win" in self._skia_api.builder_name:

	12 # This copies vulkan-1.dll that has been bundled into win_vulkan_sdk

	13 # since version 2 See skia/api BUILD_PRODUCTS_ISOLATE_WHITELIST

	14 self._skia_api.copy_build_products(

	15 self._skia_api.m.path['slave_build'].join('win_vulkan_sdk'),

	16 swarming_out_dir)

OLD	NEW