Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2188523006: Allow Core Animation compositor to use some scaled filter effects. (Closed)

Created:
4 years, 4 months ago by erikchen
Modified:
4 years, 4 months ago
Reviewers:
bajones, ccameron
CC:
chromium-reviews, jam, cc-bugs_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow Core Animation compositor to use some scaled filter effects. Filter scaling has no effect on filter effects that are not BLUR or DROP_SHADOW. BUG=581526 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/40f907eae01fd326837abcafff959df6594b7bf6 Cr-Commit-Position: refs/heads/master@{#408286}

Patch Set 1 #

Patch Set 2 : Pixel expectations. #

Patch Set 3 : Fix unit tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -5 lines) Patch
M cc/output/ca_layer_overlay.cc View 2 chunks +11 lines, -2 lines 0 comments Download
M cc/output/overlay_unittest.cc View 1 2 1 chunk +21 lines, -1 line 0 comments Download
M content/test/data/gpu/filter_effects.html View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/gpu/page_sets/pixel_tests.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
erikchen
ccameron: Please review cc/ bajones: Please review content/test/
4 years, 4 months ago (2016-07-27 21:51:25 UTC) #6
bajones
content/test/ LGTM
4 years, 4 months ago (2016-07-27 21:57:10 UTC) #7
ccameron
lgtm
4 years, 4 months ago (2016-07-27 22:00:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188523006/20001
4 years, 4 months ago (2016-07-27 22:30:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/103147)
4 years, 4 months ago (2016-07-27 22:47:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188523006/40001
4 years, 4 months ago (2016-07-27 23:17:51 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-07-28 00:08:28 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 00:11:04 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/40f907eae01fd326837abcafff959df6594b7bf6
Cr-Commit-Position: refs/heads/master@{#408286}

Powered by Google App Engine
This is Rietveld 408576698