Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Unified Diff: cc/output/ca_layer_overlay.cc

Issue 2188523006: Allow Core Animation compositor to use some scaled filter effects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit tests. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/output/overlay_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/ca_layer_overlay.cc
diff --git a/cc/output/ca_layer_overlay.cc b/cc/output/ca_layer_overlay.cc
index 8117a682d844534237aba51151e47a6930fb0d63..0fc1253662226857c4268e87ca0edf511659212b 100644
--- a/cc/output/ca_layer_overlay.cc
+++ b/cc/output/ca_layer_overlay.cc
@@ -103,8 +103,6 @@ bool ConvertAndAppendFilterOperation(
CALayerResult FromRenderPassQuad(ResourceProvider* resource_provider,
const RenderPassDrawQuad* quad,
CALayerOverlay* ca_layer_overlay) {
- if (quad->filters_scale != gfx::Vector2dF(1, 1))
- return CA_LAYER_FAILED_RENDER_PASS_FILTER_SCALE;
if (quad->background_filters.size() != 0)
return CA_LAYER_FAILED_RENDER_PASS_BACKGROUND_FILTERS;
if (quad->mask_resource_id() != 0)
@@ -117,6 +115,17 @@ CALayerResult FromRenderPassQuad(ResourceProvider* resource_provider,
return CA_LAYER_FAILED_RENDER_PASS_FILTER_OPERATION;
}
+ if (quad->filters_scale != gfx::Vector2dF(1, 1)) {
+ for (const ui::CARendererLayerParams::FilterEffect& effect :
+ ca_layer_overlay->filter_effects) {
+ using FilterEffectType = ui::CARendererLayerParams::FilterEffectType;
+ if (effect.type == FilterEffectType::BLUR ||
+ effect.type == FilterEffectType::DROP_SHADOW) {
+ return CA_LAYER_FAILED_RENDER_PASS_FILTER_SCALE;
+ }
+ }
+ }
+
ca_layer_overlay->render_pass_id = quad->render_pass_id;
ca_layer_overlay->contents_rect = gfx::RectF(0, 0, 1, 1);
« no previous file with comments | « no previous file | cc/output/overlay_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698