Fix 'Fix [turbofan] Prevent storing signalling NaNs into holey double arrays.'

Fix 'Fix [turbofan] Prevent storing signalling NaNs into holey double arrays.'

Port 52f2ceb052f63324050c7a098e4398f510b54763

Original commit message:
On MIPS different signaling NaN values must be used for hardware and simulator targets, even at snapshot generation when always simulator is used.

This introduces SilenceNaN operator, which makes sure that we only
store quiet NaNs into holey arrays. We omit the NaN silencing code
at instruction selection time if the input is an operation that
cannot possibly produce signalling NaNs.

BUG=
TEST=mjsunit/compiler/regress-store-holey-double-array

Committed: https://crrev.com/d30070d3222232c99377f577a503cb89a07faf5a
Cr-Commit-Position: refs/heads/master@{#38090}

[balazs.kilvady, 2016-07-26 16:22:16]

Description was changed from

==========
Fix 'Fix [turbofan] Prevent storing signalling NaNs into holey double arrays.'

Port 52f2ceb052f63324050c7a098e4398f510b54763

Original commit message:
On MIPS different signaling NaN values must be used for hardware and simulator
targets, even at snapshot generation when always simulator is used.

This introduces SilenceNaN operator, which makes sure that we only
store quiet NaNs into holey arrays. We omit the NaN silencing code
at instruction selection time if the input is an operation that
cannot possibly produce signalling NaNs.

BUG=
==========

to

==========
Fix 'Fix [turbofan] Prevent storing signalling NaNs into holey double arrays.'

Port 52f2ceb052f63324050c7a098e4398f510b54763

Original commit message:
On MIPS different signaling NaN values must be used for hardware and simulator
targets, even at snapshot generation when always simulator is used.

This introduces SilenceNaN operator, which makes sure that we only
store quiet NaNs into holey arrays. We omit the NaN silencing code
at instruction selection time if the input is an operation that
cannot possibly produce signalling NaNs.

BUG=
TEST=mjsunit/compiler/regress-store-holey-double-array
==========

[balazs.kilvady, 2016-07-26 16:22:16]

balazs.kilvady@imgtec.com changed reviewers:
+ akos.palfi@imgtec.com, akos.palfi@mattakis.com,
ilija.pavlovic.imgtec@gmail.com, ivica.bogosavljevic@imgtec.com,
jarin@chromium.org, machenbach@chromium.org, machenbach@google.com,
marija.antic@imgtec.com

[Michael Achenbach, 2016-07-26 19:19:21]

LGTM.

For the future I suggest having fixes in separate patchsets. Makes reviewing
much easier.

E.g.
Patchset 1: Reland original CL
Patchset 2: Add fix

[balazs.kilvady, 2016-07-27 10:32:02]

The CQ bit was checked by balazs.kilvady@imgtec.com

[commit-bot: I haz the power, 2016-07-27 10:32:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[balazs.kilvady, 2016-07-27 10:35:41]

On 2016/07/26 19:19:21, Michael Achenbach (slow) wrote:
> LGTM.
> 
> For the future I suggest having fixes in separate patchsets. Makes reviewing
> much easier.
> 
> E.g.
> Patchset 1: Reland original CL
> Patchset 2: Add fix

Yes, I see. Thanks again.

[commit-bot: I haz the power, 2016-07-27 10:55:25]

Description was changed from

==========
Fix 'Fix [turbofan] Prevent storing signalling NaNs into holey double arrays.'

Port 52f2ceb052f63324050c7a098e4398f510b54763

Original commit message:
On MIPS different signaling NaN values must be used for hardware and simulator
targets, even at snapshot generation when always simulator is used.

This introduces SilenceNaN operator, which makes sure that we only
store quiet NaNs into holey arrays. We omit the NaN silencing code
at instruction selection time if the input is an operation that
cannot possibly produce signalling NaNs.

BUG=
TEST=mjsunit/compiler/regress-store-holey-double-array
==========

to

==========
Fix 'Fix [turbofan] Prevent storing signalling NaNs into holey double arrays.'

Port 52f2ceb052f63324050c7a098e4398f510b54763

Original commit message:
On MIPS different signaling NaN values must be used for hardware and simulator
targets, even at snapshot generation when always simulator is used.

This introduces SilenceNaN operator, which makes sure that we only
store quiet NaNs into holey arrays. We omit the NaN silencing code
at instruction selection time if the input is an operation that
cannot possibly produce signalling NaNs.

BUG=
TEST=mjsunit/compiler/regress-store-holey-double-array
==========

[commit-bot: I haz the power, 2016-07-27 10:55:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-27 10:57:22]

Description was changed from

==========
Fix 'Fix [turbofan] Prevent storing signalling NaNs into holey double arrays.'

Port 52f2ceb052f63324050c7a098e4398f510b54763

Original commit message:
On MIPS different signaling NaN values must be used for hardware and simulator
targets, even at snapshot generation when always simulator is used.

This introduces SilenceNaN operator, which makes sure that we only
store quiet NaNs into holey arrays. We omit the NaN silencing code
at instruction selection time if the input is an operation that
cannot possibly produce signalling NaNs.

BUG=
TEST=mjsunit/compiler/regress-store-holey-double-array
==========

to

==========
Fix 'Fix [turbofan] Prevent storing signalling NaNs into holey double arrays.'

Port 52f2ceb052f63324050c7a098e4398f510b54763

Original commit message:
On MIPS different signaling NaN values must be used for hardware and simulator
targets, even at snapshot generation when always simulator is used.

This introduces SilenceNaN operator, which makes sure that we only
store quiet NaNs into holey arrays. We omit the NaN silencing code
at instruction selection time if the input is an operation that
cannot possibly produce signalling NaNs.

BUG=
TEST=mjsunit/compiler/regress-store-holey-double-array

Committed: https://crrev.com/d30070d3222232c99377f577a503cb89a07faf5a
Cr-Commit-Position: refs/heads/master@{#38090}
==========

[commit-bot: I haz the power, 2016-07-27 10:57:23]

Patchset 1 (id:??) landed as
https://crrev.com/d30070d3222232c99377f577a503cb89a07faf5a
Cr-Commit-Position: refs/heads/master@{#38090}