Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: src/compiler/mips/code-generator-mips.cc

Issue 2188433002: Fix 'Fix [turbofan] Prevent storing signalling NaNs into holey double arrays.' (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gypfiles/toolchain.gypi ('k') | src/globals.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/mips/code-generator-mips.cc
diff --git a/src/compiler/mips/code-generator-mips.cc b/src/compiler/mips/code-generator-mips.cc
index 169f03ef201c1e9cc00a4b2ef3ea8deca8a463c2..9d20ffcf27d0150c151622650c84e574f608a45a 100644
--- a/src/compiler/mips/code-generator-mips.cc
+++ b/src/compiler/mips/code-generator-mips.cc
@@ -1335,19 +1335,9 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
case kMipsFloat64InsertHighWord32:
__ FmoveHigh(i.OutputDoubleRegister(), i.InputRegister(1));
break;
- case kMipsFloat64SilenceNaN: {
- FPURegister value = i.InputDoubleRegister(0);
- FPURegister result = i.OutputDoubleRegister();
- Register scratch0 = i.TempRegister(0);
- Label is_nan, not_nan;
- __ BranchF(NULL, &is_nan, eq, value, value);
- __ Branch(&not_nan);
- __ bind(&is_nan);
- __ LoadRoot(scratch0, Heap::kNanValueRootIndex);
- __ ldc1(result, FieldMemOperand(scratch0, HeapNumber::kValueOffset));
- __ bind(&not_nan);
+ case kMipsFloat64SilenceNaN:
+ __ FPUCanonicalizeNaN(i.OutputDoubleRegister(), i.InputDoubleRegister(0));
break;
- }
// ... more basic instructions ...
« no previous file with comments | « gypfiles/toolchain.gypi ('k') | src/globals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698