third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.cpp - Issue 2188343002: Fix serialization of css-wide keywords in custom properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.cpp

Issue 2188343002: Fix serialization of css-wide keywords in custom properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: V3 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/variables/inherit-in-inline-style-expected.txt ('k') | third_party/WebKit/Source/core/css/StylePropertySerializer.cpp » ('j') | third_party/WebKit/Source/core/css/StylePropertySerializer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.cpp b/third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.cpp

index 5b44fee20ebffc50339db4b7f3b6e5e580e76700..09c9dcce4f48c5c3c3dc8af5a75a64ee4fc91b4c 100644

--- a/third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.cpp

+++ b/third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.cpp

@@ -17,6 +17,8 @@ String CSSCustomPropertyDeclaration::customCSSText() const

{

if (m_value)

return m_value->tokenRange().serialize();

+ if (m_valueId != CSSValueInternalVariableValue)

+ return getValueName(m_valueId);

return emptyString();

Timothy Loh 2016/07/29 01:15:06 Do we actually get here? Maybe we can just change

rwlbuis 2016/07/29 01:25:17 Right we should not hit it anymore, will add the D

}