third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.cpp - Issue 2188343002: Fix serialization of css-wide keywords in custom properties

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.cpp

Issue 2188343002: Fix serialization of css-wide keywords in custom properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: V3 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/variables/inherit-in-inline-style-expected.txt ('k') | third_party/WebKit/Source/core/css/StylePropertySerializer.cpp » ('j') | third_party/WebKit/Source/core/css/StylePropertySerializer.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "core/css/CSSCustomPropertyDeclaration.h"	5 #include "core/css/CSSCustomPropertyDeclaration.h"

6	6

7 #include "core/css/parser/CSSParserTokenRange.h"	7 #include "core/css/parser/CSSParserTokenRange.h"

8	8

9 namespace blink {	9 namespace blink {

10	10

11 DEFINE_TRACE_AFTER_DISPATCH(CSSCustomPropertyDeclaration)	11 DEFINE_TRACE_AFTER_DISPATCH(CSSCustomPropertyDeclaration)

12 {	12 {

13 CSSValue::traceAfterDispatch(visitor);	13 CSSValue::traceAfterDispatch(visitor);

14 }	14 }

15	15

16 String CSSCustomPropertyDeclaration::customCSSText() const	16 String CSSCustomPropertyDeclaration::customCSSText() const

17 {	17 {

18 if (m_value)	18 if (m_value)

19 return m_value->tokenRange().serialize();	19 return m_value->tokenRange().serialize();

	20 if (m_valueId != CSSValueInternalVariableValue)

	21 return getValueName(m_valueId);

20 return emptyString();	22 return emptyString();
	Timothy Loh 2016/07/29 01:15:06 Do we actually get here? Maybe we can just change Do we actually get here? Maybe we can just change the second if to a DCHECK rwlbuis 2016/07/29 01:25:17 Right we should not hit it anymore, will add the D Show quoted text On 2016/07/29 01:15:06, Timothy Loh wrote: > Do we actually get here? Maybe we can just change the second if to a DCHECK Right we should not hit it anymore, will add the DCHECK.
21 }	23 }

22	24

23 } // namespace blink	25 } // namespace blink

OLD	NEW