Fix serialization of css-wide keywords in custom properties

Fix serialization of css-wide keywords in custom properties

Serialize css-wide keywords in custom properties by prefixing
it with a space character and then serialing the keyword
itself (inherit/initial/unset).

BUG=632242
Committed: https://crrev.com/fffdf72e66e5aadec1c74bbbb7f4b60d4c629cfa
Cr-Commit-Position: refs/heads/master@{#408655}

[rwlbuis, 2016-07-28 19:53:59]

Description was changed from

==========
632242 WIP

BUG=
==========

to

==========
632242 WIP

BUG=632242
==========

[rwlbuis, 2016-07-28 21:22:21]

Description was changed from

==========
632242 WIP

BUG=632242
==========

to

==========
Fix serialization of css-wide keywords in custom properties

BUG=632242
==========

[rwlbuis, 2016-07-28 21:28:08]

Description was changed from

==========
Fix serialization of css-wide keywords in custom properties

BUG=632242
==========

to

==========
Fix serialization of css-wide keywords in custom properties

Serialize css-wide keywords in custom properties by prefixing it with a space
character and then serialing the keyword itself (inherit/initial/unset).

BUG=632242
==========

[rwlbuis, 2016-07-28 21:28:30]

Description was changed from

==========
Fix serialization of css-wide keywords in custom properties

Serialize css-wide keywords in custom properties by prefixing it with a space
character and then serialing the keyword itself (inherit/initial/unset).

BUG=632242
==========

to

==========
Fix serialization of css-wide keywords in custom properties

Serialize css-wide keywords in custom properties by prefixing
it with a space character and then serialing the keyword
itself (inherit/initial/unset).

BUG=632242
==========

[rwlbuis, 2016-07-28 21:49:20]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2016-07-28 21:49:21]

PTAL.

[Timothy Loh, 2016-07-29 01:15:06]

lgtm

https://codereview.chromium.org/2188343002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.cpp
(right):

https://codereview.chromium.org/2188343002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.cpp:22: return
emptyString();
Do we actually get here? Maybe we can just change the second if to a DCHECK

https://codereview.chromium.org/2188343002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/StylePropertySerializer.cpp (left):

https://codereview.chromium.org/2188343002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/StylePropertySerializer.cpp:187:
result.append(value->customCSSText());
I'd rather this line just left as is (looks odd to have the String defined
before the if() but not used until after it)

[rwlbuis, 2016-07-29 01:25:17]

Thanks for the review, will fix and land tomorrow.

https://codereview.chromium.org/2188343002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.cpp
(right):

https://codereview.chromium.org/2188343002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.cpp:22: return
emptyString();
On 2016/07/29 01:15:06, Timothy Loh wrote:
> Do we actually get here? Maybe we can just change the second if to a DCHECK

Right we should not hit it anymore, will add the DCHECK.

https://codereview.chromium.org/2188343002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/StylePropertySerializer.cpp (left):

https://codereview.chromium.org/2188343002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/StylePropertySerializer.cpp:187:
result.append(value->customCSSText());
On 2016/07/29 01:15:06, Timothy Loh wrote:
> I'd rather this line just left as is (looks odd to have the String defined
> before the if() but not used until after it)

Well spotted, I had a check on customPropertyValue in an earlier version, then
removed that check but forgot to remove the temp String.

[rwlbuis, 2016-07-29 15:17:08]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-07-29 15:17:08]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2188343002/#ps60001
(title: "Address review comments")

[commit-bot: I haz the power, 2016-07-29 15:17:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 16:33:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 16:33:05]

Failed to apply patch for
third_party/WebKit/LayoutTests/fast/css/variables/inherit-in-inline-style-expected.txt:
While running git rm
third_party/WebKit/LayoutTests/fast/css/variables/inherit-in-inline-style-expected.txt;
  fatal: pathspec
'third_party/WebKit/LayoutTests/fast/css/variables/inherit-in-inline-style-expected.txt'
did not match any files

Patch:  D   
third_party/WebKit/LayoutTests/fast/css/variables/inherit-in-inline-style-expected.txt
Index:
third_party/WebKit/LayoutTests/fast/css/variables/inherit-in-inline-style-expected.txt
diff --git
a/third_party/WebKit/LayoutTests/fast/css/variables/inherit-in-inline-style-expected.txt
b/third_party/WebKit/LayoutTests/fast/css/variables/inherit-in-inline-style-expected.txt
deleted file mode 100644
index
a16eb6d89914c41ebb77dd14d8139d6658d1841d..0000000000000000000000000000000000000000
---
a/third_party/WebKit/LayoutTests/fast/css/variables/inherit-in-inline-style-expected.txt
+++ /dev/null
@@ -1,6 +0,0 @@
-This is a testharness.js-based test.
-FAIL The special inherit value can be read from inline style. assert_equals:
expected " inherit" but got ""
-FAIL The special inherit value can be read after setting. assert_equals:
expected " inherit" but got ""
-FAIL The special inherit value can be read from a declared rule. assert_equals:
expected " inherit" but got ""
-Harness: the test ran to completion.
-

[commit-bot: I haz the power, 2016-07-29 16:37:34]

Description was changed from

==========
Fix serialization of css-wide keywords in custom properties

Serialize css-wide keywords in custom properties by prefixing
it with a space character and then serialing the keyword
itself (inherit/initial/unset).

BUG=632242
==========

to

==========
Fix serialization of css-wide keywords in custom properties

Serialize css-wide keywords in custom properties by prefixing
it with a space character and then serialing the keyword
itself (inherit/initial/unset).

BUG=632242

Committed: https://crrev.com/fffdf72e66e5aadec1c74bbbb7f4b60d4c629cfa
Cr-Commit-Position: refs/heads/master@{#408655}
==========

[commit-bot: I haz the power, 2016-07-29 16:37:35]

Patchset 4 (id:??) landed as
https://crrev.com/fffdf72e66e5aadec1c74bbbb7f4b60d4c629cfa
Cr-Commit-Position: refs/heads/master@{#408655}