Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2188333002:
Roll ICU to ef5c7353 from b5ecbb29 (Closed)
|
Created:
4 years, 4 months ago by jungshik at Google Modified:
4 years, 4 months ago Reviewers:
Michael Achenbach CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll ICU to ef5c7353 from b5ecbb29
1. Update the IANA timezone DB to 2016f from 2016d.
2. Add support for Big Endian (should not affect Chrome builds) mainly for v8
embedders (mips/mips64 BE targets).
3. Make it possible to run foreign trybots.
For more details, see
https://chromium.googlesource.com/chromium/deps/icu.git/+log/b5ecbb29..ef5c7353
TBR=machenbach@chromium.org
BUG=473288, v8:4828
TEST=Try the following in d8 or Chrome's JS console:
> (new Date("07/23/2016 12:00Z")).toLocaleString("en", {timeZone:
"Asia/Novosibirsk"})
7/23/2016, 6:00:00 PM
> (new Date("07/24/2016 12:00Z")).toLocaleString("en", {timeZone:
"Asia/Novosibirsk"})
7/24/2016, 7:00:00 PM
Committed: https://crrev.com/29f718da9b8179fcb96fc0c1aa2c608bab6f19d3
Cr-Commit-Position: refs/heads/master@{#408797}
Patch Set 1 #Patch Set 2 : roll icu to HEAD~1 (exclude timezone update) #Patch Set 3 : roll ICU only to pre-GN-change #Patch Set 4 : roll ICU to a revision with isolate_test fix #Messages
Total messages: 34 (22 generated)
Description was changed from ========== Roll ICU to 4ba0bcf3 from b5ecbb29 1. Update the IANA timezone DB to 2016f from 2016d. 2. Add support for Big Endian (should not affect Chrome builds) mainly for v8 embedders (mips/mips64 BE targets). 3. Make it possible to run foreign trybots. For more details, see https://chromium.googlesource.com/chromium/deps/icu.git/+log/b5ecbb29..4ba0bcf3 BUG=473288,v8:4828 TEST=Try the following in d8 or Chrome's JS console: > (new Date("07/23/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/23/2016, 6:00:00 PM > (new Date("07/24/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/24/2016, 7:00:00 PM ========== to ========== Roll ICU to 4ba0bcf3 from b5ecbb29 1. Update the IANA timezone DB to 2016f from 2016d. 2. Add support for Big Endian (should not affect Chrome builds) mainly for v8 embedders (mips/mips64 BE targets). 3. Make it possible to run foreign trybots. For more details, see https://chromium.googlesource.com/chromium/deps/icu.git/+log/b5ecbb29..4ba0bcf3 TBR=machenbach@chromium.org BUG=473288,v8:4828 TEST=Try the following in d8 or Chrome's JS console: > (new Date("07/23/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/23/2016, 6:00:00 PM > (new Date("07/24/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/24/2016, 7:00:00 PM ==========
jshin@chromium.org changed reviewers: + machenbach@chromium.org
The CQ bit was checked by jshin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by jshin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by jshin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/07/29 06:02:35, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... This is really strange. There are a large number of tests failing that have nothing to do with ICU. ICU-related tests that failed pass when I run them locally
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm if trybots pass
The CQ bit was checked by jshin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by jshin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Roll ICU to 4ba0bcf3 from b5ecbb29 1. Update the IANA timezone DB to 2016f from 2016d. 2. Add support for Big Endian (should not affect Chrome builds) mainly for v8 embedders (mips/mips64 BE targets). 3. Make it possible to run foreign trybots. For more details, see https://chromium.googlesource.com/chromium/deps/icu.git/+log/b5ecbb29..4ba0bcf3 TBR=machenbach@chromium.org BUG=473288,v8:4828 TEST=Try the following in d8 or Chrome's JS console: > (new Date("07/23/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/23/2016, 6:00:00 PM > (new Date("07/24/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/24/2016, 7:00:00 PM ========== to ========== Roll ICU to ef5c7353 from b5ecbb29 1. Update the IANA timezone DB to 2016f from 2016d. 2. Add support for Big Endian (should not affect Chrome builds) mainly for v8 embedders (mips/mips64 BE targets). 3. Make it possible to run foreign trybots. For more details, see https://chromium.googlesource.com/chromium/deps/icu.git/+log/b5ecbb29..ef5c7353 TBR=machenbach@chromium.org BUG=473288,v8:4828 TEST=Try the following in d8 or Chrome's JS console: > (new Date("07/23/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/23/2016, 6:00:00 PM > (new Date("07/24/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/24/2016, 7:00:00 PM ==========
Description was changed from ========== Roll ICU to ef5c7353 from b5ecbb29 1. Update the IANA timezone DB to 2016f from 2016d. 2. Add support for Big Endian (should not affect Chrome builds) mainly for v8 embedders (mips/mips64 BE targets). 3. Make it possible to run foreign trybots. For more details, see https://chromium.googlesource.com/chromium/deps/icu.git/+log/b5ecbb29..ef5c7353 TBR=machenbach@chromium.org BUG=473288,v8:4828 TEST=Try the following in d8 or Chrome's JS console: > (new Date("07/23/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/23/2016, 6:00:00 PM > (new Date("07/24/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/24/2016, 7:00:00 PM ========== to ========== Roll ICU to ef5c7353 from b5ecbb29 1. Update the IANA timezone DB to 2016f from 2016d. 2. Add support for Big Endian (should not affect Chrome builds) mainly for v8 embedders (mips/mips64 BE targets). 3. Make it possible to run foreign trybots. For more details, see https://chromium.googlesource.com/chromium/deps/icu.git/+log/b5ecbb29..ef5c7353 TBR=machenbach@chromium.org BUG=473288,v8:4828 TEST=Try the following in d8 or Chrome's JS console: > (new Date("07/23/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/23/2016, 6:00:00 PM > (new Date("07/24/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/24/2016, 7:00:00 PM ==========
The CQ bit was checked by jshin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from machenbach@chromium.org Link to the patchset: https://codereview.chromium.org/2188333002/#ps60001 (title: "roll ICU to a revision with isolate_test fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/07/29 06:04:13, jungshik at google wrote: > On 2016/07/29 06:02:35, commit-bot: I haz the power wrote: > > CQ is trying da patch. Follow status at > > > > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... > > This is really strange. There are a large number of tests failing that have > nothing to do with ICU. ICU-related tests that failed pass when I run them > locally It turned out that my GN change broke 'swarm testing'. 'isolate_tests' didn't copy icudtl.dat to slave bots. I fixed that in ICU and am rolling to that revision. ( https://codereview.chromium.org/2197523002 )
Message was sent while issue was closed.
Description was changed from ========== Roll ICU to ef5c7353 from b5ecbb29 1. Update the IANA timezone DB to 2016f from 2016d. 2. Add support for Big Endian (should not affect Chrome builds) mainly for v8 embedders (mips/mips64 BE targets). 3. Make it possible to run foreign trybots. For more details, see https://chromium.googlesource.com/chromium/deps/icu.git/+log/b5ecbb29..ef5c7353 TBR=machenbach@chromium.org BUG=473288,v8:4828 TEST=Try the following in d8 or Chrome's JS console: > (new Date("07/23/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/23/2016, 6:00:00 PM > (new Date("07/24/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/24/2016, 7:00:00 PM ========== to ========== Roll ICU to ef5c7353 from b5ecbb29 1. Update the IANA timezone DB to 2016f from 2016d. 2. Add support for Big Endian (should not affect Chrome builds) mainly for v8 embedders (mips/mips64 BE targets). 3. Make it possible to run foreign trybots. For more details, see https://chromium.googlesource.com/chromium/deps/icu.git/+log/b5ecbb29..ef5c7353 TBR=machenbach@chromium.org BUG=473288,v8:4828 TEST=Try the following in d8 or Chrome's JS console: > (new Date("07/23/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/23/2016, 6:00:00 PM > (new Date("07/24/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/24/2016, 7:00:00 PM ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Roll ICU to ef5c7353 from b5ecbb29 1. Update the IANA timezone DB to 2016f from 2016d. 2. Add support for Big Endian (should not affect Chrome builds) mainly for v8 embedders (mips/mips64 BE targets). 3. Make it possible to run foreign trybots. For more details, see https://chromium.googlesource.com/chromium/deps/icu.git/+log/b5ecbb29..ef5c7353 TBR=machenbach@chromium.org BUG=473288,v8:4828 TEST=Try the following in d8 or Chrome's JS console: > (new Date("07/23/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/23/2016, 6:00:00 PM > (new Date("07/24/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/24/2016, 7:00:00 PM ========== to ========== Roll ICU to ef5c7353 from b5ecbb29 1. Update the IANA timezone DB to 2016f from 2016d. 2. Add support for Big Endian (should not affect Chrome builds) mainly for v8 embedders (mips/mips64 BE targets). 3. Make it possible to run foreign trybots. For more details, see https://chromium.googlesource.com/chromium/deps/icu.git/+log/b5ecbb29..ef5c7353 TBR=machenbach@chromium.org BUG=473288,v8:4828 TEST=Try the following in d8 or Chrome's JS console: > (new Date("07/23/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/23/2016, 6:00:00 PM > (new Date("07/24/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/24/2016, 7:00:00 PM Committed: https://crrev.com/29f718da9b8179fcb96fc0c1aa2c608bab6f19d3 Cr-Commit-Position: refs/heads/master@{#408797} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/29f718da9b8179fcb96fc0c1aa2c608bab6f19d3 Cr-Commit-Position: refs/heads/master@{#408797} |
