Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2188313003: Revert of Silence -Wclobbered in each file that needs it. (Closed)

Created:
4 years, 4 months ago by mtklein
Modified:
4 years, 4 months ago
Reviewers:
msarett, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Silence -Wclobbered in each file that needs it. (patchset #2 id:20001 of https://codereview.chromium.org/2184823009/ ) Reason for revert: Jpeg strategy seems to be leading to crashes. Gonna go back to warning squelch. Original issue's description: > Silence -Wclobbered in each file that needs it. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184823009 > > Committed: https://skia.googlesource.com/skia/+/03f704a343d7a82974f977eda8789a8c721c93e5 TBR=msarett@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/2f428966c680d6d9e38d6ff1d16fe1999412d2fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -18 lines) Patch
M gyp/codec.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/codec/SkJpegCodec.cpp View 8 chunks +7 lines, -13 lines 0 comments Download
M src/codec/SkPngCodec.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
mtklein
Created Revert of Silence -Wclobbered in each file that needs it.
4 years, 4 months ago (2016-07-28 20:59:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188313003/1
4 years, 4 months ago (2016-07-28 20:59:56 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 21:00:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2f428966c680d6d9e38d6ff1d16fe1999412d2fd

Powered by Google App Engine
This is Rietveld 408576698