src/codec/SkPngCodec.cpp - Issue 2188313003: Revert of Silence -Wclobbered in each file that needs it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkPngCodec.cpp

Issue 2188313003: Revert of Silence -Wclobbered in each file that needs it. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkPngCodec.cpp

diff --git a/src/codec/SkPngCodec.cpp b/src/codec/SkPngCodec.cpp

index b8916f9de7f254536850095cd0b67f8cafbbcd6d..ee72af58ad46c517e3ec63da18746d4fe69257ef 100644

--- a/src/codec/SkPngCodec.cpp

+++ b/src/codec/SkPngCodec.cpp

@@ -19,11 +19,6 @@

#include "SkSwizzler.h"

#include "SkTemplates.h"

#include "SkUtils.h"

-// This warning triggers false postives way too often in here.

-#if defined(__GNUC__) && !defined(__clang__)

- #pragma GCC diagnostic ignored "-Wclobbered"

-#endif

///////////////////////////////////////////////////////////////////////////////

// Callback functions

« no previous file with comments | « src/codec/SkJpegCodec.cpp ('k') | no next file » | no next file with comments »