Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2188243002: Add jar_excluded_patterns support in android_aar_prebuilt (Closed)

Created:
4 years, 4 months ago by bshe
Modified:
4 years, 4 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add jar_excluded_patterns support in android_aar_prebuilt Gvr library needs to exclude protobuf classes(chromium has its own version) in order to link properly with chromium. This CL adds "jar_excluded_patterns" support for android_aar_prebuilt BUG=632730 Committed: https://crrev.com/396c2c1f6b3ff0183dcd27b8044442c9f5ba05e4 Cr-Commit-Position: refs/heads/master@{#408667}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/config/android/rules.gni View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
bshe
Hi Andrew. Do you mind to take a look at this bug? Thanks! Biao
4 years, 4 months ago (2016-07-29 14:34:26 UTC) #3
agrieve
On 2016/07/29 14:34:26, bshe wrote: > Hi Andrew. > > Do you mind to take ...
4 years, 4 months ago (2016-07-29 16:02:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188243002/1
4 years, 4 months ago (2016-07-29 16:18:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 17:09:45 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 17:12:21 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/396c2c1f6b3ff0183dcd27b8044442c9f5ba05e4
Cr-Commit-Position: refs/heads/master@{#408667}

Powered by Google App Engine
This is Rietveld 408576698