Fix nullptr deref in remote interface acquisition

Fix nullptr deref in remote interface acquisition

Changes MessagePipeReader to drop remote associated interface
requests if the pipe has been closed. This avoids dereferencing
a null |sender_| instance.

Also adds a sanity check to
ChannelProxy::GetGenericRemoteAssociatedInterface() to ensure it's
never called before Init(). We aren't hitting this today but it
clarifies that the method has the same expectations as
ChannelProxy::Send().

BUG=632263
R=yzshen@chromium.org

Committed: https://crrev.com/5a90895a195ff140b0b355754807944f6824bd90
Cr-Commit-Position: refs/heads/master@{#408458}

[Ken Rockot(use gerrit already), 2016-07-28 17:35:07]

Description was changed from

==========
Fix nullptr deref in remote interface acquisition

Changes MessagePipeReader to drop remote associated interface
requests if the pipe has been closed. This avoids dereferencing
a null |sender_| instance.

Also adds a sanity check to
ChannelProxy::GetGenericRemoteAssociatedInterface() to ensure it's
never called before Init(). This mirrors the expectations of
ChannelProxy::Send().

BUG=632263
R=yzshen@chromium.org
==========

to

==========
Fix nullptr deref in remote interface acquisition

Changes MessagePipeReader to drop remote associated interface
requests if the pipe has been closed. This avoids dereferencing
a null |sender_| instance.

Also adds a sanity check to
ChannelProxy::GetGenericRemoteAssociatedInterface() to ensure it's
never called before Init(). We aren't hitting this today but it
clarifies that the method has the same expectations as
ChannelProxy::Send().

BUG=632263
R=yzshen@chromium.org
==========

[Ken Rockot(use gerrit already), 2016-07-28 17:35:23]

Please take a look!

[yzshen1, 2016-07-28 17:45:47]

On 2016/07/28 17:35:23, Ken Rockot wrote:
> Please take a look!

Lgtm

[Ken Rockot(use gerrit already), 2016-07-28 17:46:15]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-07-28 17:46:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 20:08:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-28 20:10:02]

Description was changed from

==========
Fix nullptr deref in remote interface acquisition

Changes MessagePipeReader to drop remote associated interface
requests if the pipe has been closed. This avoids dereferencing
a null |sender_| instance.

Also adds a sanity check to
ChannelProxy::GetGenericRemoteAssociatedInterface() to ensure it's
never called before Init(). We aren't hitting this today but it
clarifies that the method has the same expectations as
ChannelProxy::Send().

BUG=632263
R=yzshen@chromium.org
==========

to

==========
Fix nullptr deref in remote interface acquisition

Changes MessagePipeReader to drop remote associated interface
requests if the pipe has been closed. This avoids dereferencing
a null |sender_| instance.

Also adds a sanity check to
ChannelProxy::GetGenericRemoteAssociatedInterface() to ensure it's
never called before Init(). We aren't hitting this today but it
clarifies that the method has the same expectations as
ChannelProxy::Send().

BUG=632263
R=yzshen@chromium.org

Committed: https://crrev.com/5a90895a195ff140b0b355754807944f6824bd90
Cr-Commit-Position: refs/heads/master@{#408458}
==========

[commit-bot: I haz the power, 2016-07-28 20:10:02]

Patchset 1 (id:??) landed as
https://crrev.com/5a90895a195ff140b0b355754807944f6824bd90
Cr-Commit-Position: refs/heads/master@{#408458}