Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Unified Diff: ipc/ipc_message_pipe_reader.cc

Issue 2188173003: Fix nullptr deref in remote interface acquisition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_channel_proxy.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_message_pipe_reader.cc
diff --git a/ipc/ipc_message_pipe_reader.cc b/ipc/ipc_message_pipe_reader.cc
index 8e1b35565bfec09fbabb25835542fbd3e403f627..32c9f9e0c924e5e5be87c450314595bce5ed3a47 100644
--- a/ipc/ipc_message_pipe_reader.cc
+++ b/ipc/ipc_message_pipe_reader.cc
@@ -116,6 +116,8 @@ bool MessagePipeReader::Send(std::unique_ptr<Message> message) {
void MessagePipeReader::GetRemoteInterface(
const std::string& name,
mojo::ScopedInterfaceEndpointHandle handle) {
+ if (!sender_.is_bound())
+ return;
mojom::GenericInterfaceAssociatedRequest request;
request.Bind(std::move(handle));
sender_->GetAssociatedInterface(name, std::move(request));
« no previous file with comments | « ipc/ipc_channel_proxy.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698