Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: cc/trees/layer_tree_impl.h

Issue 2188093002: cc: Complete swap promise for aborted commit after pending activation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: post rebase fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/layer_tree_host_unittest.cc ('k') | cc/trees/layer_tree_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_impl.h
diff --git a/cc/trees/layer_tree_impl.h b/cc/trees/layer_tree_impl.h
index 3d032fcc50bf7998f0b1382491b6891ad30072a0..0f629ba9e93b43158e36f864b87c842949f487d7 100644
--- a/cc/trees/layer_tree_impl.h
+++ b/cc/trees/layer_tree_impl.h
@@ -358,9 +358,12 @@ class CC_EXPORT LayerTreeImpl {
// on the active tree if a new tree is activated.
void QueuePinnedSwapPromise(std::unique_ptr<SwapPromise> swap_promise);
- // Take the |new_swap_promise| and append it to |swap_promise_list_|.
+ // Takes ownership of |new_swap_promises|. Existing swap promises in
+ // |swap_promise_list_| are cancelled (SWAP_FAILS).
void PassSwapPromises(
- std::vector<std::unique_ptr<SwapPromise>>* new_swap_promise);
+ std::vector<std::unique_ptr<SwapPromise>> new_swap_promises);
+ void AppendSwapPromises(
+ std::vector<std::unique_ptr<SwapPromise>> new_swap_promises);
void FinishSwapPromises(CompositorFrameMetadata* metadata);
void BreakSwapPromises(SwapPromise::DidNotSwapReason reason);
« no previous file with comments | « cc/trees/layer_tree_host_unittest.cc ('k') | cc/trees/layer_tree_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698