Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: cc/trees/layer_tree_impl.h

Issue 2188093002: cc: Complete swap promise for aborted commit after pending activation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: post rebase fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/trees/layer_tree_host_unittest.cc ('k') | cc/trees/layer_tree_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_TREES_LAYER_TREE_IMPL_H_ 5 #ifndef CC_TREES_LAYER_TREE_IMPL_H_
6 #define CC_TREES_LAYER_TREE_IMPL_H_ 6 #define CC_TREES_LAYER_TREE_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 340 matching lines...) Expand 10 before | Expand all | Expand 10 after
351 // may only be queued on the active tree. 351 // may only be queued on the active tree.
352 // 352 //
353 // An active tree pinned swap promise will see only DidSwap() or 353 // An active tree pinned swap promise will see only DidSwap() or
354 // DidNotSwap(SWAP_FAILS). No DidActivate() will be seen because 354 // DidNotSwap(SWAP_FAILS). No DidActivate() will be seen because
355 // that has already happened prior to queueing of the swap promise. 355 // that has already happened prior to queueing of the swap promise.
356 // 356 //
357 // Pinned active tree swap promises will not be broken prematurely 357 // Pinned active tree swap promises will not be broken prematurely
358 // on the active tree if a new tree is activated. 358 // on the active tree if a new tree is activated.
359 void QueuePinnedSwapPromise(std::unique_ptr<SwapPromise> swap_promise); 359 void QueuePinnedSwapPromise(std::unique_ptr<SwapPromise> swap_promise);
360 360
361 // Take the |new_swap_promise| and append it to |swap_promise_list_|. 361 // Takes ownership of |new_swap_promises|. Existing swap promises in
362 // |swap_promise_list_| are cancelled (SWAP_FAILS).
362 void PassSwapPromises( 363 void PassSwapPromises(
363 std::vector<std::unique_ptr<SwapPromise>>* new_swap_promise); 364 std::vector<std::unique_ptr<SwapPromise>> new_swap_promises);
365 void AppendSwapPromises(
366 std::vector<std::unique_ptr<SwapPromise>> new_swap_promises);
364 void FinishSwapPromises(CompositorFrameMetadata* metadata); 367 void FinishSwapPromises(CompositorFrameMetadata* metadata);
365 void BreakSwapPromises(SwapPromise::DidNotSwapReason reason); 368 void BreakSwapPromises(SwapPromise::DidNotSwapReason reason);
366 369
367 void DidModifyTilePriorities(); 370 void DidModifyTilePriorities();
368 371
369 ResourceId ResourceIdForUIResource(UIResourceId uid) const; 372 ResourceId ResourceIdForUIResource(UIResourceId uid) const;
370 void ProcessUIResourceRequestQueue(); 373 void ProcessUIResourceRequestQueue();
371 374
372 bool IsUIResourceOpaque(UIResourceId uid) const; 375 bool IsUIResourceOpaque(UIResourceId uid) const;
373 376
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
550 553
551 std::unique_ptr<PendingPageScaleAnimation> pending_page_scale_animation_; 554 std::unique_ptr<PendingPageScaleAnimation> pending_page_scale_animation_;
552 555
553 private: 556 private:
554 DISALLOW_COPY_AND_ASSIGN(LayerTreeImpl); 557 DISALLOW_COPY_AND_ASSIGN(LayerTreeImpl);
555 }; 558 };
556 559
557 } // namespace cc 560 } // namespace cc
558 561
559 #endif // CC_TREES_LAYER_TREE_IMPL_H_ 562 #endif // CC_TREES_LAYER_TREE_IMPL_H_
OLDNEW
« no previous file with comments | « cc/trees/layer_tree_host_unittest.cc ('k') | cc/trees/layer_tree_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698