Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2188033005: Add note page to options. (Closed)

Created:
4 years, 4 months ago by jdufault
Modified:
4 years, 4 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@stylus-settings
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add note page to options. BUG=616112 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/614a811e6f9b0318d95a68efc189d89f172fe8f1 Cr-Commit-Position: refs/heads/master@{#409022}

Patch Set 1 : Initial upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -2 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/browser_options.css View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 chunk +6 lines, -0 lines 0 comments Download
A + chrome/browser/resources/options/chromeos/note_overlay.css View 1 chunk +3 lines, -2 lines 0 comments Download
A chrome/browser/resources/options/chromeos/note_overlay.html View 1 chunk +31 lines, -0 lines 0 comments Download
A chrome/browser/resources/options/chromeos/note_overlay.js View 1 chunk +34 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/options.html View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/options.js View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/options_bundle.js View 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/options/chromeos/options_note_handler.h View 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/options/chromeos/options_note_handler.cc View 1 chunk +42 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 25 (20 generated)
jdufault
Steven, PTAL. Thanks!
4 years, 4 months ago (2016-08-01 17:26:19 UTC) #18
stevenjb
lgtm
4 years, 4 months ago (2016-08-01 17:38:47 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188033005/40001
4 years, 4 months ago (2016-08-01 18:03:17 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 4 months ago (2016-08-01 19:27:05 UTC) #23
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 19:29:48 UTC) #25
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/614a811e6f9b0318d95a68efc189d89f172fe8f1
Cr-Commit-Position: refs/heads/master@{#409022}

Powered by Google App Engine
This is Rietveld 408576698