Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2187713005: [Merge M53] Apply autofill profile use-date fix after sync starts. (Closed)

Created:
4 years, 4 months ago by Mathieu
Modified:
4 years, 4 months ago
Reviewers:
Mathieu, sebsg, Nicolas Zea
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Merge M53] Apply autofill profile use-date fix after sync starts. The use-date fix replaces invalid autofill profile last-use dates (prior to M53, the use-date at creation was set to 0). It is currently run when the autofill profile data is first loaded upon chrome start. This happens before sync, if enabled, has started. Unfortunately, when sync starts, it overwrites the fixed last-use dates for any profiles already represented in the sync data stream. This CL moves the invocation of... autofill::PersonalDataManager::ApplyProfileUseDatesFix() ... to be invoked either upon determining that sync is not enabled (and will therefore not clobber the fixes) or upon notification that sync has started (initial sync is complete, and sync is ready to accept and propagate our fixes). BUG=631141 R=mathp@chromium.org, sebsg@chromium.org, zea@chromium.org Review-Url: https://codereview.chromium.org/2177253003 Cr-Commit-Position: refs/heads/master@{#407859} (cherry picked from commit fde6213417d148d604e67d687ac8259cc60ea90d) Committed: https://chromium.googlesource.com/chromium/src/+/68d68c77ceb103b17bc4b305b1ba0a65666c4985

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M components/autofill/core/browser/personal_data_manager.cc View 3 chunks +14 lines, -4 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service_autofill_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Mathieu
4 years, 4 months ago (2016-07-27 17:56:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
68d68c77ceb103b17bc4b305b1ba0a65666c4985 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698