Apply autofill profile use-date fix after sync starts.

Apply autofill profile use-date fix after sync starts.

The use-date fix replaces invalid autofill profile last-use dates (prior
to M53, the use-date at creation was set to 0). It is currently run when
the autofill profile data is first loaded upon chrome start. This
happens before sync, if enabled, has started. Unfortunately, when sync
starts, it overwrites the fixed last-use dates for any profiles already
represented in the sync data stream.

This CL moves the invocation of...

  autofill::PersonalDataManager::ApplyProfileUseDatesFix()

... to be invoked either upon determining that sync is not enabled
(and will therefore not clobber the fixes) or upon notification
that sync has started (initial sync is complete, and sync is
ready to accept and propagate our fixes).

BUG=631141
R=mathp@chromium.org, sebsg@chromium.org, zea@chromium.org

Committed: https://crrev.com/fde6213417d148d604e67d687ac8259cc60ea90d
Cr-Commit-Position: refs/heads/master@{#407859}

[Roger McFarlane (Chromium), 2016-07-25 19:28:03]

rogerm@chromium.org changed reviewers:
+ zea@chromium.org

[Roger McFarlane (Chromium), 2016-07-25 19:28:03]

Please take a look?

Trigger the use-date fix (one-shot) post start-of-sync if sync is enabled.

[Roger McFarlane (Chromium), 2016-07-25 19:28:17]

The CQ bit was checked by rogerm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 19:28:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mathieu, 2016-07-25 19:35:37]

lgtm thanks

[commit-bot: I haz the power, 2016-07-25 20:56:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 20:56:50]

Dry run: This issue passed the CQ dry run.

[Roger McFarlane (Chromium), 2016-07-26 15:45:28]

On 2016/07/25 19:35:37, Mathieu Perreault wrote:
> lgtm thanks

Thanks!

zea@... ping?

[Roger McFarlane (Chromium), 2016-07-26 15:47:01]

Description was changed from

==========
Apply autofill profile use-date fix after sync starts.

The use-date fix replaces invalid autofill profile last-use dates (prior
to M53, the use-date at creation was set to 0). It is currently run when
the autofill profile data is first loaded upon chrome start. This
happens before sync, if enabled, has started. Unfortunately, when sync
starts, it overwrites the fixed last-use dates for any profiles already
represented in the sync data stream.

This CL moves the invocation of...

  autofill::PersonalDataManager::ApplyProfileUseDatesFix()

... to be invoked either upon determining that sync is not enabled
(and will therefore not clobber the fixes) or upon notification
that sync has started (initial sync is complete, and sync is
ready to accept and propagate our fixes).

BUG=631141
R=mathp@chromium.org, sebsg@chromium.org
==========

to

==========
Apply autofill profile use-date fix after sync starts.

The use-date fix replaces invalid autofill profile last-use dates (prior
to M53, the use-date at creation was set to 0). It is currently run when
the autofill profile data is first loaded upon chrome start. This
happens before sync, if enabled, has started. Unfortunately, when sync
starts, it overwrites the fixed last-use dates for any profiles already
represented in the sync data stream.

This CL moves the invocation of...

  autofill::PersonalDataManager::ApplyProfileUseDatesFix()

... to be invoked either upon determining that sync is not enabled
(and will therefore not clobber the fixes) or upon notification
that sync has started (initial sync is complete, and sync is
ready to accept and propagate our fixes).

BUG=631141
R=mathp@chromium.org, sebsg@chromium.org, zea@chromium.org
==========

[Nicolas Zea, 2016-07-26 18:30:14]

sync lgtm

[Roger McFarlane (Chromium), 2016-07-26 18:31:00]

The CQ bit was checked by rogerm@chromium.org

[commit-bot: I haz the power, 2016-07-26 18:32:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 18:37:49]

Description was changed from

==========
Apply autofill profile use-date fix after sync starts.

The use-date fix replaces invalid autofill profile last-use dates (prior
to M53, the use-date at creation was set to 0). It is currently run when
the autofill profile data is first loaded upon chrome start. This
happens before sync, if enabled, has started. Unfortunately, when sync
starts, it overwrites the fixed last-use dates for any profiles already
represented in the sync data stream.

This CL moves the invocation of...

  autofill::PersonalDataManager::ApplyProfileUseDatesFix()

... to be invoked either upon determining that sync is not enabled
(and will therefore not clobber the fixes) or upon notification
that sync has started (initial sync is complete, and sync is
ready to accept and propagate our fixes).

BUG=631141
R=mathp@chromium.org, sebsg@chromium.org, zea@chromium.org
==========

to

==========
Apply autofill profile use-date fix after sync starts.

The use-date fix replaces invalid autofill profile last-use dates (prior
to M53, the use-date at creation was set to 0). It is currently run when
the autofill profile data is first loaded upon chrome start. This
happens before sync, if enabled, has started. Unfortunately, when sync
starts, it overwrites the fixed last-use dates for any profiles already
represented in the sync data stream.

This CL moves the invocation of...

  autofill::PersonalDataManager::ApplyProfileUseDatesFix()

... to be invoked either upon determining that sync is not enabled
(and will therefore not clobber the fixes) or upon notification
that sync has started (initial sync is complete, and sync is
ready to accept and propagate our fixes).

BUG=631141
R=mathp@chromium.org, sebsg@chromium.org, zea@chromium.org
==========

[commit-bot: I haz the power, 2016-07-26 18:37:50]

Committed patchset #1 (id:1)

[sebsg, 2016-07-26 18:38:16]

Forgot to hit send: LGTM!

[commit-bot: I haz the power, 2016-07-26 18:40:25]

Description was changed from

==========
Apply autofill profile use-date fix after sync starts.

The use-date fix replaces invalid autofill profile last-use dates (prior
to M53, the use-date at creation was set to 0). It is currently run when
the autofill profile data is first loaded upon chrome start. This
happens before sync, if enabled, has started. Unfortunately, when sync
starts, it overwrites the fixed last-use dates for any profiles already
represented in the sync data stream.

This CL moves the invocation of...

  autofill::PersonalDataManager::ApplyProfileUseDatesFix()

... to be invoked either upon determining that sync is not enabled
(and will therefore not clobber the fixes) or upon notification
that sync has started (initial sync is complete, and sync is
ready to accept and propagate our fixes).

BUG=631141
R=mathp@chromium.org, sebsg@chromium.org, zea@chromium.org
==========

to

==========
Apply autofill profile use-date fix after sync starts.

The use-date fix replaces invalid autofill profile last-use dates (prior
to M53, the use-date at creation was set to 0). It is currently run when
the autofill profile data is first loaded upon chrome start. This
happens before sync, if enabled, has started. Unfortunately, when sync
starts, it overwrites the fixed last-use dates for any profiles already
represented in the sync data stream.

This CL moves the invocation of...

  autofill::PersonalDataManager::ApplyProfileUseDatesFix()

... to be invoked either upon determining that sync is not enabled
(and will therefore not clobber the fixes) or upon notification
that sync has started (initial sync is complete, and sync is
ready to accept and propagate our fixes).

BUG=631141
R=mathp@chromium.org, sebsg@chromium.org, zea@chromium.org

Committed: https://crrev.com/fde6213417d148d604e67d687ac8259cc60ea90d
Cr-Commit-Position: refs/heads/master@{#407859}
==========

[commit-bot: I haz the power, 2016-07-26 18:40:26]

Patchset 1 (id:??) landed as
https://crrev.com/fde6213417d148d604e67d687ac8259cc60ea90d
Cr-Commit-Position: refs/heads/master@{#407859}