Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2187713004: [interpreter] Use ForInFilter stub. (Closed)

Created:
4 years, 4 months ago by oth
Modified:
4 years, 4 months ago
Reviewers:
mythria, rmcilroy
CC:
v8-reviews_googlegroups.com, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Use ForInFilter stub. BUG=v8:4280 LOG=N Committed: https://crrev.com/31eefa438ad2777de69010c37a6e99786c2b3fb3 Cr-Commit-Position: refs/heads/master@{#38100}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/interpreter/interpreter.cc View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 15 (8 generated)
oth
Mythri, PTAL, moving to Camillo's call stub for ForInFilter. Thanks!
4 years, 4 months ago (2016-07-27 12:55:17 UTC) #4
mythria
lgtm. Thanks, Mythri
4 years, 4 months ago (2016-07-27 12:56:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187713004/1
4 years, 4 months ago (2016-07-27 13:26:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 13:27:59 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/31eefa438ad2777de69010c37a6e99786c2b3fb3 Cr-Commit-Position: refs/heads/master@{#38100}
4 years, 4 months ago (2016-07-27 13:31:40 UTC) #12
rmcilroy
https://codereview.chromium.org/2187713004/diff/1/src/interpreter/interpreter.cc File src/interpreter/interpreter.cc (right): https://codereview.chromium.org/2187713004/diff/1/src/interpreter/interpreter.cc#newcode2045 src/interpreter/interpreter.cc:2045: Node* result = __ CallStub(callable, context, key, receiver); Any ...
4 years, 4 months ago (2016-08-05 14:10:51 UTC) #14
oth
4 years, 4 months ago (2016-08-08 08:16:19 UTC) #15
Message was sent while issue was closed.
On 2016/08/05 14:10:51, rmcilroy wrote:
>
https://codereview.chromium.org/2187713004/diff/1/src/interpreter/interpreter.cc
> File src/interpreter/interpreter.cc (right):
> 
>
https://codereview.chromium.org/2187713004/diff/1/src/interpreter/interpreter...
> src/interpreter/interpreter.cc:2045: Node* result = __ CallStub(callable,
> context, key, receiver);
> Any reason you didn't inline this TF stub into the bytecode handler?

No. https://codereview.chromium.org/2220343002

Powered by Google App Engine
This is Rietveld 408576698