Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2220343002: [interpreter] Inline ForInFilter stub. (Closed)

Created:
4 years, 4 months ago by oth
Modified:
4 years, 4 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Inline ForInFilter stub. BUG=v8:4280 LOG=N Committed: https://crrev.com/2bf0b8c8ed5d0c93982c8c227e93622aceecea16 Cr-Commit-Position: refs/heads/master@{#38420}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/interpreter/interpreter.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
oth
PTAL. Had to remove the deferred block annotation for if_slow path to avoid CHECK hitting. ...
4 years, 4 months ago (2016-08-08 08:16:09 UTC) #4
rmcilroy
Thanks! I wasn't expecting a CL, I was just wondering if there was a reason, ...
4 years, 4 months ago (2016-08-08 08:30:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220343002/1
4 years, 4 months ago (2016-08-08 09:04:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 09:07:04 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2bf0b8c8ed5d0c93982c8c227e93622aceecea16 Cr-Commit-Position: refs/heads/master@{#38420}
4 years, 4 months ago (2016-08-08 09:07:25 UTC) #12
rmcilroy
4 years, 4 months ago (2016-08-12 13:34:03 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2238283002/ by rmcilroy@chromium.org.

The reason for reverting is: Speculative revert to possible performance
regressions.

BUG=chromium:635826,chromium:635930.

Powered by Google App Engine
This is Rietveld 408576698