Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2187713003: [MD settings] propagate stopKeyboardEventPropagation to paper-input (Closed)

Created:
4 years, 4 months ago by dschuyler
Modified:
4 years, 4 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] propagate stopKeyboardEventPropagation to paper-input This CL passes stopKeyboardEventPropagation from settings-input to the underlying paper-input and then uses that property to keep the focus in the home page url setting. BUG=621480 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0ba8786cfbc72edbdb38e37bcc9b29d0ac0696ee Cr-Commit-Position: refs/heads/master@{#408451}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -21 lines) Patch
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/settings_input.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/settings_input.js View 1 chunk +5 lines, -19 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dschuyler
4 years, 4 months ago (2016-07-26 23:14:01 UTC) #5
stevenjb
lgtm
4 years, 4 months ago (2016-07-27 16:39:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187713003/1
4 years, 4 months ago (2016-07-28 18:15:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 19:15:27 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 19:17:53 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ba8786cfbc72edbdb38e37bcc9b29d0ac0696ee
Cr-Commit-Position: refs/heads/master@{#408451}

Powered by Google App Engine
This is Rietveld 408576698