Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Unified Diff: chrome/browser/resources/settings/controls/settings_input.js

Issue 2187713003: [MD settings] propagate stopKeyboardEventPropagation to paper-input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/controls/settings_input.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/controls/settings_input.js
diff --git a/chrome/browser/resources/settings/controls/settings_input.js b/chrome/browser/resources/settings/controls/settings_input.js
index 37801d892204ed9f08b2b27a14321a53e55f28d6..9ddf8383e4795f4635bab30c7ab03bb70f96eeb8 100644
--- a/chrome/browser/resources/settings/controls/settings_input.js
+++ b/chrome/browser/resources/settings/controls/settings_input.js
@@ -22,43 +22,29 @@ Polymer({
observer: 'prefChanged_'
},
- /**
- * The current value of the input, reflected to/from |pref|.
- */
+ /* The current value of the input, reflected to/from |pref|. */
value: {
type: String,
value: '',
notify: true,
},
- /**
- * Set to true to disable editing the input.
- */
+ /* Set to true to disable editing the input. */
disabled: {
type: Boolean,
value: false,
reflectToAttribute: true
},
- /** Propagate the errorMessage property. */
+ /* Properties for paper-input. This is not strictly necessary.
+ * Though it does define the types for the closure compiler. */
errorMessage: { type: String },
-
- /** Propagate the label property. */
label: { type: String },
-
- /** Propagate the no-label-float property. */
noLabelFloat: { type: Boolean, value: false },
-
- /** Propagate the pattern property. */
pattern: { type: String },
-
- /** Propagate the readonly property. */
readonly: { type: Boolean, value: false },
-
- /** Propagate the required property. */
required: { type: Boolean, value: false },
-
- /** Propagate the type property. */
+ stopKeyboardEventPropagation: { type: Boolean, value: false },
type: { type: String },
},
« no previous file with comments | « chrome/browser/resources/settings/controls/settings_input.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698