Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1426)

Unified Diff: src/builtins/builtins-utils.h

Issue 2187693002: [Tracing] Embed V8 runtime call stats into tracing. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/builtins/builtins-utils.h
diff --git a/src/builtins/builtins-utils.h b/src/builtins/builtins-utils.h
index f84d10a4a734bf23545a59150e38d855065d0c1a..13f426bcfbff84b0aa7b89eaa65685173402d800 100644
--- a/src/builtins/builtins-utils.h
+++ b/src/builtins/builtins-utils.h
@@ -85,8 +85,6 @@ class BuiltinArguments : public Arguments {
int args_length, Object** args_object, Isolate* isolate) { \
BuiltinArguments args(args_length, args_object); \
RuntimeCallTimerScope timer(isolate, &RuntimeCallStats::Builtin_##name); \
- TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.runtime"), \
- "V8.Builtin_" #name); \
return Builtin_Impl_##name(args, isolate); \
} \
\
@@ -97,7 +95,10 @@ class BuiltinArguments : public Arguments {
return Builtin_Impl_Stats_##name(args_length, args_object, isolate); \
} \
BuiltinArguments args(args_length, args_object); \
- return Builtin_Impl_##name(args, isolate); \
+ TRACE_EVENT_RUNTIME_CALL_STATS_TRACING_SCOPED( \
+ isolate, &tracing::TraceEventStatsTable::Builtin_##name); \
+ Object* result = Builtin_Impl_##name(args, isolate); \
Camillo Bruni 2016/07/27 08:29:07 The same as for the runtime functions. I'd like to
+ return result; \
} \
\
MUST_USE_RESULT static Object* Builtin_Impl_##name(BuiltinArguments args, \

Powered by Google App Engine
This is Rietveld 408576698