[Tracing] Embed V8 runtime call stats into tracing.

src/builtins/builtins-utils.h

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_BUILTINS_BUILTINS_UTILS_H_
 #define V8_BUILTINS_BUILTINS_UTILS_H_
 
 #include "src/arguments.h"
 #include "src/base/logging.h"
 #include "src/builtins/builtins.h"
@@ skipping 67 matching lines @@
 // enabled.
 // TODO(cbruni): Convert the IsContext CHECK back to a DCHECK.
 #define BUILTIN(name)                                                        \
   MUST_USE_RESULT static Object* Builtin_Impl_##name(BuiltinArguments args,  \
                                                      Isolate* isolate);      \
                                                                              \
   V8_NOINLINE static Object* Builtin_Impl_Stats_##name(                      \
       int args_length, Object** args_object, Isolate* isolate) {             \
     BuiltinArguments args(args_length, args_object);                         \
     RuntimeCallTimerScope timer(isolate, &RuntimeCallStats::Builtin_##name); \
-    TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.runtime"),                    \
-                 "V8.Builtin_" #name);                                       \
     return Builtin_Impl_##name(args, isolate);                               \
   }                                                                          \
                                                                              \
   MUST_USE_RESULT Object* Builtin_##name(                                    \
       int args_length, Object** args_object, Isolate* isolate) {             \
     CHECK(isolate->context() == nullptr || isolate->context()->IsContext()); \
     if (FLAG_runtime_call_stats) {                                           \
       return Builtin_Impl_Stats_##name(args_length, args_object, isolate);   \
     }                                                                        \
     BuiltinArguments args(args_length, args_object);                         \
-    return Builtin_Impl_##name(args, isolate);                               \
+    TRACE_EVENT_RUNTIME_CALL_STATS_TRACING_SCOPED(                           \
+        isolate, &tracing::TraceEventStatsTable::Builtin_##name);            \
+    Object* result = Builtin_Impl_##name(args, isolate);                     \

[Camillo Bruni, 2016/07/27 08:29:07]

The same as for the runtime functions.
I'd like to keep all timers and stack-allocated scopes away from the default
functions.

+    return result;                                                           \
   }                                                                          \
                                                                              \
   MUST_USE_RESULT static Object* Builtin_Impl_##name(BuiltinArguments args,  \
                                                      Isolate* isolate)
 
 // ----------------------------------------------------------------------------
 
 #define CHECK_RECEIVER(Type, name, method)                                  \
   if (!args.receiver()->Is##Type()) {                                       \
     THROW_NEW_ERROR_RETURN_FAILURE(                                         \
@@ skipping 16 matching lines @@
                      isolate->factory()->NewStringFromAsciiChecked(method))); \
   }                                                                           \
   Handle<String> name;                                                        \
   ASSIGN_RETURN_FAILURE_ON_EXCEPTION(                                         \
       isolate, name, Object::ToString(isolate, args.receiver()))
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_BUILTINS_BUILTINS_UTILS_H_