Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2187503002: binding: Returns null if there is no valid event handler. (Closed)

Created:
4 years, 4 months ago by Yuki
Modified:
4 years, 4 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Returns null if there is no valid event handler. Simply makes DOM attributes for event handlers return null if there is no event handler. BUG=613671 Committed: https://crrev.com/f6c6da33a4f1a2125f393a525bbecee5a096add7 Cr-Commit-Position: refs/heads/master@{#408109}

Patch Set 1 #

Patch Set 2 : Updated the layout test expectation. #

Messages

Total messages: 18 (11 generated)
Yuki
Could you review this CL?
4 years, 4 months ago (2016-07-26 14:09:54 UTC) #3
haraken
LGTM. Thanks for the quick fix!
4 years, 4 months ago (2016-07-26 14:32:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187503002/1
4 years, 4 months ago (2016-07-27 05:43:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/262931)
4 years, 4 months ago (2016-07-27 07:00:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187503002/20001
4 years, 4 months ago (2016-07-27 13:26:55 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-27 13:30:24 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 13:31:57 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f6c6da33a4f1a2125f393a525bbecee5a096add7
Cr-Commit-Position: refs/heads/master@{#408109}

Powered by Google App Engine
This is Rietveld 408576698