third_party/WebKit/Source/bindings/scripts/v8_types.py - Issue 2187503002: binding: Returns null if there is no valid event handler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_types.py

Issue 2187503002: binding: Returns null if there is no valid event handler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated the layout test expectation. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/v8_types.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_types.py b/third_party/WebKit/Source/bindings/scripts/v8_types.py

index 353c2a2645bac0f0930377189cad73acb99ad911..5b4c8ebd3ad3b48a685d30066d806e1652738bd4 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_types.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_types.py

@@ -862,7 +862,11 @@ CPP_VALUE_TO_V8_VALUE = {

'StringOrNull': '{cpp_value}.isNull() ? v8::Local<v8::Value>(v8::Null({isolate})) : v8String({isolate}, {cpp_value})',

# Special cases

'Dictionary': '{cpp_value}.v8Value()',

- 'EventHandler': '{cpp_value} ? v8::Local<v8::Value>(V8AbstractEventListener::cast({cpp_value})->getListenerObject(impl->getExecutionContext())) : v8::Local<v8::Value>(v8::Null({isolate}))',

+ 'EventHandler': (

+ '{cpp_value} ? ' +

+ 'V8AbstractEventListener::cast({cpp_value})->getListenerOrNull(' +

+ '{isolate}, impl->getExecutionContext()) : ' +

+ 'v8::Null({isolate}).As<v8::Value>()'),

'ScriptValue': '{cpp_value}.v8Value()',

'SerializedScriptValue': '{cpp_value} ? {cpp_value}->deserialize() : v8::Local<v8::Value>(v8::Null({isolate}))',

# General