Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyleConstants.h

Issue 2187493004: Add a generated ComputedStyleBase class that ComputedStyle extends (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_make_visibility_enum_class_rebase
Patch Set: Rebase onto fast path patches Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyleConstants.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyleConstants.h b/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
index 61646e5585c7fa94f3a741bd64ad68a6b3e8939b..3376f695bf557bf57806765e86c9a0a4d9e375d7 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
@@ -26,6 +26,7 @@
#ifndef ComputedStyleConstants_h
#define ComputedStyleConstants_h
+#include "core/ComputedStyleBaseConstants.h"
#include <cstddef>
namespace blink {
@@ -403,10 +404,6 @@ enum ECaptionSide {
enum EListStylePosition { ListStylePositionOutside, ListStylePositionInside };
-// TODO(sashab): Add a static_assert when this is used in bitfields to ensure it
-// uses unsigned as the underlying type.
-enum class EVisibility : unsigned { Visible, Hidden, Collapse };
-
enum ECursor {
// The following must match the order in CSSValueKeywords.in.
CURSOR_AUTO,

Powered by Google App Engine
This is Rietveld 408576698