Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: third_party/WebKit/Source/core/css/CSSProperties.in

Issue 2187493004: Add a generated ComputedStyleBase class that ComputedStyle extends (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_make_visibility_enum_class_rebase
Patch Set: Rebase onto fast path patches Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSProperties.in
diff --git a/third_party/WebKit/Source/core/css/CSSProperties.in b/third_party/WebKit/Source/core/css/CSSProperties.in
index 77117dae4cdbc15bcb1fce840b1c5719e896b28b..e9836f67bf056f7c7c6c92cc9f4e52af75dd7e96 100644
--- a/third_party/WebKit/Source/core/css/CSSProperties.in
+++ b/third_party/WebKit/Source/core/css/CSSProperties.in
@@ -23,6 +23,21 @@
// The property is a shorthand for several other properties.
+// keyword_only
+// These properties only store keyword values. This is used when
+// generating the ComputedStyle storage for the property. The initial
+// value for this property on a ComputedStyle is the first keyword in
+// the specified list of keywords.
+// TODO(sashab, meade): Remove this once TypedOM types are specified for
+// every property, since this value can be inferred from that.
+
+
+// - keywords=[keyword1|keyword2]
+// This specifies all valid keyword values for the property.
+// TODO(sashab): Once all properties are represented here, delete
+// CSSValueKeywords.in and use this list instead.
ojan 2016/09/07 03:46:10 <3
+
+
// Flags which go into CSSOMTypes:
// - typedom_types=[Type|OtherType]
// The property can take types specified in typedom_types for CSS Typed OM.
@@ -342,7 +357,7 @@ transition-timing-function custom_all
unicode-bidi
vector-effect svg
vertical-align interpolable, custom_inherit, custom_value
-visibility interpolable, inherited, independent
+visibility interpolable, inherited, independent, keyword_only, keywords=[visible|hidden|collapse]
x interpolable, svg, converter=convertLength
y interpolable, svg, converter=convertLength
-webkit-appearance type_name=ControlPart

Powered by Google App Engine
This is Rietveld 408576698