Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 2187383002: Updating comment changing bevavior -> behavior (Closed)

Created:
4 years, 4 months ago by danbev
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
git@github.com:danbev/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Updating comment changing bevavior -> behavior BUG= Review-Url: https://codereview.chromium.org/2187383002 Cr-Commit-Position: refs/heads/master@{#42378} Committed: https://chromium.googlesource.com/v8/v8/+/3e4c170bc7f0f8ceb73fee904d83a253b1cb7c99

Patch Set 1 #

Patch Set 2 : correct typo in comment change bevavior -> behavior #

Patch Set 3 : correct typo in comment change bevavior -> behavior #

Patch Set 4 : correct typo in comment change bevavior -> behavior #

Patch Set 5 : correct typo in comment change bevavior -> behavior #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/v8.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
danbev
4 years, 4 months ago (2016-07-28 17:53:48 UTC) #2
danbev
Rebased with upstream/master.
4 years, 3 months ago (2016-09-23 11:51:02 UTC) #3
danbev
Rebased with upstream master. Would you giving this a review?
4 years, 2 months ago (2016-10-13 06:42:47 UTC) #4
danbev
I've rebased this old change set as I noticed the typo is still there. Would ...
3 years, 11 months ago (2017-01-16 13:30:15 UTC) #6
jochen (gone - plz use gerrit)
Hey, thanks for uploading the patch! It looks like during the rebase something went wrong. ...
3 years, 11 months ago (2017-01-16 13:48:22 UTC) #8
danbev
On 2017/01/16 13:48:22, jochen wrote: > Hey, > > thanks for uploading the patch! It ...
3 years, 11 months ago (2017-01-16 14:16:41 UTC) #9
danbev
Rebased again after resetting and cherry picking.
3 years, 11 months ago (2017-01-16 14:17:54 UTC) #11
jochen (gone - plz use gerrit)
lgtm, thx
3 years, 11 months ago (2017-01-16 14:19:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187383002/60001
3 years, 11 months ago (2017-01-16 14:25:35 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 14:53:32 UTC) #17
Message was sent while issue was closed.
Committed patchset #5 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/3e4c170bc7f0f8ceb73fee904d83a253b1c...

Powered by Google App Engine
This is Rietveld 408576698