Generating autocomplete results with and without word breaks in the Omnibox.

components/omnibox/browser/url_index_private_data.h

Index: components/omnibox/browser/url_index_private_data.h
diff --git a/components/omnibox/browser/url_index_private_data.h b/components/omnibox/browser/url_index_private_data.h
index 100692cd7b44e63de9bfbc2b01c3501a6e2bbd95..9c8549c0e1f90201bbfdfaaf827f276d5245cf39 100644
--- a/components/omnibox/browser/url_index_private_data.h
+++ b/components/omnibox/browser/url_index_private_data.h
@@ -50,6 +50,25 @@ class URLIndexPrivateData
  public:
   URLIndexPrivateData();
 
+  // Returns history URL matches

[Mark P, 2016/08/18 19:36:53]

This comment doesn't say anything useful.  You want a comment that describes
what the function does.  I'd suggest something in the same style as the comment
by HistoryItemsForTerms or something that says, This helper function is much
like HistoryItemsForTerms() except ...

[Lavar Askew, 2016/08/19 04:46:07]

Done.

+  ScoredHistoryMatches GetScoredItemsForSearchString(
+      const base::string16& search_string,
+      const HistoryIDSet& history_id_set,
+      const size_t& max_matches,

[Mark P, 2016/08/18 19:36:53]

nit: please remove the & here; it's not useful

[Lavar Askew, 2016/08/19 04:46:07]

Done.

+      bookmarks::BookmarkModel* bookmark_model,
+      TemplateURLService* template_url_service);
+
+  // Returns a vector of individual words based in the base::string16
+  // search_string. Each index of the vector represents a single word
+  // in the search_string.

[Mark P, 2016/08/18 19:36:53]

nit: shorter and clearer:
// Returns a vector of individual words from |search_string|, in order of
appearance, duplicates allowed.

+  String16Vector ExtractIndividualWordVector(
+      const base::string16& search_string);
+
+  // Given a base::string16 in |term_string|, scans the history index and

[Mark P, 2016/08/18 19:36:53]

nit: omit "base::string16" -- this is obvious from the function declaration.

[Lavar Askew, 2016/08/19 04:46:07]

Done.

+  // returns the set of history item IDs.  Will return an emptyHistoryIDSet

[Mark P, 2016/08/18 19:36:53]

after IDs, add "containing all the terms in |term_string|"
(or something similar)

[Lavar Askew, 2016/08/19 04:46:07]

Done.

+  // if the index has not been initialized or the search string has no words.
+  HistoryIDSet GetHistoryIDSet(const String16Vector& lower_words);
+
   // Given a base::string16 in |term_string|, scans the history index and
   // returns a vector with all scored, matching history items. The
   // |term_string| is broken down into individual terms (words), each of which