Generating autocomplete results with and without word breaks in the Omnibox.

components/omnibox/browser/url_index_private_data.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OMNIBOX_BROWSER_URL_INDEX_PRIVATE_DATA_H_
 #define COMPONENTS_OMNIBOX_BROWSER_URL_INDEX_PRIVATE_DATA_H_
 
 #include <stddef.h>
 
 #include <set>
@@ skipping 32 matching lines @@
 // this class is for exclusive use by the InMemoryURLIndex class there should
 // be no calls from any other class.
 //
 // All public member functions are called on the main thread unless otherwise
 // annotated.
 class URLIndexPrivateData
     : public base::RefCountedThreadSafe<URLIndexPrivateData> {
  public:
   URLIndexPrivateData();
 
+  // Returns history URL matches

[Mark P, 2016/08/18 19:36:53]

This comment doesn't say anything useful.  You want a comment that describes
what the function does.  I'd suggest something in the same style as the comment
by HistoryItemsForTerms or something that says, This helper function is much
like HistoryItemsForTerms() except ...

[Lavar Askew, 2016/08/19 04:46:07]

Done.

+  ScoredHistoryMatches GetScoredItemsForSearchString(
+      const base::string16& search_string,
+      const HistoryIDSet& history_id_set,
+      const size_t& max_matches,

[Mark P, 2016/08/18 19:36:53]

nit: please remove the & here; it's not useful

[Lavar Askew, 2016/08/19 04:46:07]

Done.

+      bookmarks::BookmarkModel* bookmark_model,
+      TemplateURLService* template_url_service);
+
+  // Returns a vector of individual words based in the base::string16
+  // search_string. Each index of the vector represents a single word
+  // in the search_string.

[Mark P, 2016/08/18 19:36:53]

nit: shorter and clearer:
// Returns a vector of individual words from |search_string|, in order of
appearance, duplicates allowed.

+  String16Vector ExtractIndividualWordVector(
+      const base::string16& search_string);
+
+  // Given a base::string16 in |term_string|, scans the history index and

[Mark P, 2016/08/18 19:36:53]

nit: omit "base::string16" -- this is obvious from the function declaration.

[Lavar Askew, 2016/08/19 04:46:07]

Done.

+  // returns the set of history item IDs.  Will return an emptyHistoryIDSet

[Mark P, 2016/08/18 19:36:53]

after IDs, add "containing all the terms in |term_string|"
(or something similar)

[Lavar Askew, 2016/08/19 04:46:07]

Done.

+  // if the index has not been initialized or the search string has no words.
+  HistoryIDSet GetHistoryIDSet(const String16Vector& lower_words);
+
   // Given a base::string16 in |term_string|, scans the history index and
   // returns a vector with all scored, matching history items. The
   // |term_string| is broken down into individual terms (words), each of which
   // must occur in the candidate history item's URL or page title for the item
   // to qualify; however, the terms do not necessarily have to be adjacent. We
   // also allow breaking |term_string| at |cursor_position| (if
   // set). Once we have a set of candidates, they are filtered to ensure
   // that all |term_string| terms, as separated by whitespace and the
   // cursor (if set), occur within the candidate's URL or page title.
   // Scores are then calculated on no more than |kItemsToScoreLimit|
@@ skipping 324 matching lines @@
   int saved_cache_version_;
 
   // Used for unit testing only. Records the number of candidate history items
   // at three stages in the index searching process.
   size_t pre_filter_item_count_;    // After word index is queried.
   size_t post_filter_item_count_;   // After trimming large result set.
   size_t post_scoring_item_count_;  // After performing final filter/scoring.
 };
 
 #endif  // COMPONENTS_OMNIBOX_BROWSER_URL_INDEX_PRIVATE_DATA_H_