Remove KeyboardUmaEventFilter

Remove KeyboardUmaEventFilter

Metric is no longer used (either by code, or by anyone)

BUG=631204
Committed: https://crrev.com/0f22cebd743e5c6681a2bb05549021ff393da9a3
Cr-Commit-Position: refs/heads/master@{#408500}

[girard, 2016-07-28 14:12:20]

girard@chromium.org changed reviewers:
+ derat@chromium.org, mkwst@chromium.org

[girard, 2016-07-28 14:12:20]

mkwst@chromium.org: Please review changes in histograms.xml (removing one value,
and replacing an owner who has left)

derat@chromium.org: Please review changes in the rest of the patch - fairly
simple removal.

[Mike West, 2016-07-28 14:17:46]

Sorry, I'm only in the histograms OWNERS file for Blink-side UseCounter
changes. You'll need a real owner (from //tools/metrics/OWNERS) for your
change.

On Thursday, 28 July 2016, <girard@chromium.org> wrote:

> Reviewers: Mike West, Daniel Erat
> CL: https://codereview.chromium.org/2187303002/
>
> Message:
> mkwst@chromium.org <javascript:_e(%7B%7D,'cvml','mkwst@chromium.org');>:
> Please review changes in histograms.xml (removing one value,
> and replacing an owner who has left)
>
> derat@chromium.org <javascript:_e(%7B%7D,'cvml','derat@chromium.org');>:
> Please review changes in the rest of the patch - fairly
> simple removal.
>
>
>
> Description:
> Remove KeyboardUmaEventFilter
>
> Metric is no longer used (either by code, or by anyone)
>
> BUG=631204
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+2, -101 lines):
> M ash/ash.gyp
> D ash/keyboard_uma_event_filter.h
> D ash/keyboard_uma_event_filter.cc
> M ash/shell.cc
> M tools/metrics/histograms/histograms.xml
>
>
>

-- 
-mike

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Daniel Erat, 2016-07-28 14:33:59]

lgtm for ash/

[girard, 2016-07-28 14:34:31]

girard@chromium.org changed reviewers:
+ isherman@chromium.org
- mkwst@chromium.org

[girard, 2016-07-28 14:34:32]

Ilya - PTAL at histograms.xml

[Ilya Sherman, 2016-07-28 17:22:29]

https://codereview.chromium.org/2187303002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2187303002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:20150: -<histogram
name="Keyboard.KeystrokeDeltas" units="ms">
Please mark this metric as <obsolete> rather than removing the metadata.

[girard, 2016-07-28 18:45:29]

On 2016/07/28 17:22:29, Ilya Sherman wrote:
>
https://codereview.chromium.org/2187303002/diff/20001/tools/metrics/histogram...
> File tools/metrics/histograms/histograms.xml (left):
> 
>
https://codereview.chromium.org/2187303002/diff/20001/tools/metrics/histogram...
> tools/metrics/histograms/histograms.xml:20150: -<histogram
> name="Keyboard.KeystrokeDeltas" units="ms">
> Please mark this metric as <obsolete> rather than removing the metadata.

Ah! Thanks - fixed.

[Ilya Sherman, 2016-07-28 19:41:47]

LGTM -- thanks for the cleanup!

[girard, 2016-07-28 19:58:45]

The CQ bit was checked by girard@chromium.org

[girard, 2016-07-28 19:58:46]

The patchset sent to the CQ was uploaded after l-g-t-m from derat@chromium.org
Link to the patchset: https://codereview.chromium.org/2187303002/#ps40001
(title: "Flagged histogram as obsolete.")

[commit-bot: I haz the power, 2016-07-28 19:59:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 20:11:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 20:11:30]

Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[girard, 2016-07-28 21:28:29]

The CQ bit was checked by girard@chromium.org

[girard, 2016-07-28 21:28:29]

The patchset sent to the CQ was uploaded after l-g-t-m from derat@chromium.org,
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2187303002/#ps60001
(title: "Removing references to KeyboardUMAEventFilter")

[commit-bot: I haz the power, 2016-07-28 21:29:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 22:35:25]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-28 22:36:48]

Description was changed from

==========
Remove KeyboardUmaEventFilter

Metric is no longer used (either by code, or by anyone)

BUG=631204
==========

to

==========
Remove KeyboardUmaEventFilter

Metric is no longer used (either by code, or by anyone)

BUG=631204

Committed: https://crrev.com/0f22cebd743e5c6681a2bb05549021ff393da9a3
Cr-Commit-Position: refs/heads/master@{#408500}
==========

[commit-bot: I haz the power, 2016-07-28 22:36:52]

Patchset 4 (id:??) landed as
https://crrev.com/0f22cebd743e5c6681a2bb05549021ff393da9a3
Cr-Commit-Position: refs/heads/master@{#408500}