Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3256)

Unified Diff: ash/keyboard_uma_event_filter.cc

Issue 2187303002: Remove KeyboardUmaEventFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing references to KeyboardUMAEventFilter Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/keyboard_uma_event_filter.h ('k') | ash/shell.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/keyboard_uma_event_filter.cc
diff --git a/ash/keyboard_uma_event_filter.cc b/ash/keyboard_uma_event_filter.cc
deleted file mode 100644
index 064ce0e273e89dca28f890c5c1c4660b6cc46648..0000000000000000000000000000000000000000
--- a/ash/keyboard_uma_event_filter.cc
+++ /dev/null
@@ -1,48 +0,0 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "ash/keyboard_uma_event_filter.h"
-
-#include "base/metrics/histogram.h"
-#include "ui/events/event.h"
-
-namespace {
-
-// This threshold is used to drop keystrokes that are more than some time apart.
-// These keystrokes are dropped to avoid recording outliers, as well as pauses
-// between actual segments of typing.
-const int kKeystrokeThresholdInSeconds = 5;
-}
-
-namespace ash {
-
-KeyboardUMAEventFilter::KeyboardUMAEventFilter() {}
-
-KeyboardUMAEventFilter::~KeyboardUMAEventFilter() {}
-
-void KeyboardUMAEventFilter::OnKeyEvent(ui::KeyEvent* event) {
- // This is a rough approximation, so assume that each key release is the
- // result of a typed key.
- if (event->type() != ui::ET_KEY_RELEASED)
- return;
-
- // Reset the timer on non-character keystrokes.
- if (!isprint(event->GetCharacter())) {
- last_keystroke_time_ = base::TimeTicks();
- return;
- }
-
- if (last_keystroke_time_.ToInternalValue() == 0) {
- last_keystroke_time_ = event->time_stamp();
- return;
- }
-
- base::TimeDelta delta = event->time_stamp() - last_keystroke_time_;
- if (delta < base::TimeDelta::FromSeconds(kKeystrokeThresholdInSeconds))
- UMA_HISTOGRAM_TIMES("Keyboard.KeystrokeDeltas", delta);
-
- last_keystroke_time_ = event->time_stamp();
-}
-
-} // namespace ash
« no previous file with comments | « ash/keyboard_uma_event_filter.h ('k') | ash/shell.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698